Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: doesn't send DL_VALUES if there are a lot of settings #1344

Closed
flixr opened this issue Sep 12, 2015 · 6 comments · Fixed by #1364
Closed

server: doesn't send DL_VALUES if there are a lot of settings #1344

flixr opened this issue Sep 12, 2015 · 6 comments · Fixed by #1364
Assignees
Milestone

Comments

@flixr
Copy link
Member

flixr commented Sep 12, 2015

When you add more settings, at some point server doesn't send DL_VALUES anymore with
Discarding long ivy message DL_VALUES (1240 bytes)

What is this Ivy bug the limit of 1000 chars in message_send in pprz.ml is supposed to prevent?

@flixr
Copy link
Member Author

flixr commented Sep 21, 2015

@gautierhattenberger @alex31 any idea why there is this limitation?

@gautierhattenberger
Copy link
Member

Actually, Ivy should support long messages since 2008, but Pascal added this check in 2009. We should try to remove it and see because their is no reasons to keep it from what I can see.

@flixr
Copy link
Member Author

flixr commented Sep 22, 2015

So what is the maximum length now?
I guess it would still make sense to prevent endlessly long messages?

@gautierhattenberger
Copy link
Member

there is an initial malloc and a realloc if needed, so I guess the limit is the available memory... but yes, limiting stupidly long message is probably wise
the initial alloc is around 4000 bytes I think.

@flixr
Copy link
Member Author

flixr commented Sep 22, 2015

So we limit it to 4000 or 10000 or so?

@gautierhattenberger
Copy link
Member

tested and working

@flixr flixr added this to the v5.8 milestone Nov 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants