Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCS spams unfinished sentences #1833

Closed
EwoudSmeur opened this issue Aug 2, 2016 · 3 comments · Fixed by #1842
Closed

GCS spams unfinished sentences #1833

EwoudSmeur opened this issue Aug 2, 2016 · 3 comments · Fixed by #1842
Labels

Comments

@EwoudSmeur
Copy link
Member

After the successful resolution of #1046, I am back with a new issue. The GCS still does not finish some sentences because it starts a new one and can in some cases start to spam messages. This can happen for instance when you turn off a drone, if I remember correctly it can then start to alternate between "all links lost" and "approaching".

Now, the approaching message is actually the one I feel is the least interesting message of them all, though you hear it most often.

@flixr flixr added the GCS label Aug 2, 2016
@gautierhattenberger
Copy link
Member

I was also thinking of removing it, but a nicer option I think would be to trigger the "approaching" only if you actually flew a minimum distance (it is only useful when flying long segment after all).

@dewagter
Copy link
Member

dewagter commented Aug 2, 2016

It often alternates between for instance "Battery Low" and another message.

-Christophe

On Tue, Aug 2, 2016 at 10:50 PM, Gautier Hattenberger <
notifications@github.com> wrote:

I was also thinking of removing it, but a nicer option I think would be to
trigger the "approaching" only if you actually flew a minimum distance (it
is only useful when flying long segment after all).


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1833 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAd6fM7K97wsLA0rLXp4zNya4kQyTT4jks5qb62fgaJpZM4JamH8
.

@EwoudSmeur
Copy link
Member Author

That would be useful. Or maybe an option to disable the approaching message would be nice? I was not completely aware of the function of the approaching message, initially I thought it was approaching HOME. Now I understand it is to notify the operator that the drone is about to finish a segment. However, if I check what it does in the simulator for rotorcraft it says approaching every time it leaves for a new waypoint...

Perhaps stopping all messages for drones that lost link (or everything except link loss) would be nice. Now sometimes when you turn off a drone you get spammed to death, while there is little use of messages when there is no link

gautierhattenberger added a commit that referenced this issue Aug 16, 2016
only triggered when close enough but not too much, and flying a long segment
fix #1833
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants