-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't attempt to download further tiles if google blocked you #42
Comments
It seems there is no really easy way to do this when using wget (as we do in sw/lib/ocaml/http.ml) |
maybe add --server-response as in example wget --server-response http://localhost/nx.file 2>&1 | awk '/^ HTTP/{print $2}' Or else maybe a real a http lib from ocaml e.g. http://ocaml-http.forge.ocamlcore.org/examples/basic_auth.ml. |
@gautierhattenberger I tried to quickly fix this by using the Http_client from ocamlnet |
@flixr I compiled your code this morning and it seems to work like a charm. I tried to reach the download limit by getting a lot of tiles from GM, but couldn't in the end... (the limit seems higher than what I thought, or did they increased it recently ? ) |
Two reasons it didn't seem to work properly for me:
This is fixed in the pull request. Would be good if you could have a look at it though... I also just tried to reach the limit again, was unable to reach it... so this is untested. |
Regarding the google maps limit resulting in a 403: |
partially fixed with #276 |
+1 and also, maybe there is a way of downloading the tiles without risking to be blocked by google? |
short answer: no |
closing, as it doesn't seem to occur anymore with the new code.... |
* ARTag markers * Add new message REMOTE_GPS_LOCAL and way to parse it Made for indoor navigation in wide space * [pprzlink] Added REMOTE_GPS_LOCAL message * New airframe + small fixes * Slamdunk GPS and avoidance Real full commit * Repush of each actual changes Fighting with Git isn't an easy thing * Undoing TUDelft merge * [Slamdunk] Last updates
* ARTag markers * Add new message REMOTE_GPS_LOCAL and way to parse it Made for indoor navigation in wide space * [pprzlink] Added REMOTE_GPS_LOCAL message * New airframe + small fixes * Slamdunk GPS and avoidance Real full commit * Repush of each actual changes Fighting with Git isn't an easy thing * Undoing TUDelft merge * [Slamdunk] Last updates
When trying to download map tiles and you get a ERROR 403: Forbidden. it should abort trying to download the rest as well. Since then you are temporarily blocked by Google and there is no point in trying to download the rest. Also print a more descriptive error message saying that you are probably temporarily blocked by google
see sw/lib/ocaml/gm.ml
The text was updated successfully, but these errors were encountered: