Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

items in the georef menu of Flight Plan Editor are not updated after closing or editing plan #927

Closed
alonsoac opened this issue Nov 5, 2014 · 4 comments
Closed

items in the georef menu of Flight Plan Editor are not updated after closing or editing plan #927

alonsoac opened this issue Nov 5, 2014 · 4 comments
Labels
GCS
Milestone
v5.4

Comments

@alonsoac
Copy link
Contributor

alonsoac commented Nov 5, 2014

Hi. When closing a flight plan I would expect the corresponding items from the menu would be removed. When deleting a waypoint the item should be removed. When changing the name of a waypoint the item should be renamed.
@flixr flixr added the GCS label Nov 5, 2014
@OpenUAS OpenUAS modified the milestone: v5.6 Nov 11, 2014
@alonsoac
Copy link
Contributor Author

Hi. I was wondering why this was not given more urgency. I think this is very confusing for new users. Perhaps closing and opening another plan should be disabled until this is fixed then.

@gautierhattenberger
Copy link
Member

When it comes to ocaml code, it usually has the priority I can give to it. So hopeful it will be solved in v5.6.

@flixr
Copy link
Member

flixr commented Dec 29, 2014

I agree that this is quite annoying and a fix would be appreciated.

But it also seems like we had this bug for a looong time and nobody really noticed and/or complained about this. Maybe not many people use the editor that way (closing a flight plan and opening a new one).

IMHO there are more important issues to spend time on, so at least for myself this does not have a high prio...

@alonsoac
Copy link
Contributor Author

I am working on fixing the following problems:

  • deleting a wp from Waypoint Edit dialog or from XML editor does not remove the item from the georefs menus
  • deleting a wp does not remove it from sectors
  • changing the name of a wp in xml editor or in dialog does not update the menus or sectors
  • closing a flight plan does not clear the menus
  • creating a new wp by inserting a new xml item or by copying an existing item does not add the wp to the window or the menus

I expect to send a pull request or patch soon that fixes most of these issues.

@alonsoac alonsoac mentioned this issue Jan 1, 2015
Closed
@flixr flixr modified the milestones: v5.4, v5.6 Jan 5, 2015
Fab7c4 pushed a commit to Fab7c4/paparazzi that referenced this issue Apr 11, 2015
Merge tag 'v5.4.0_stable' into highwind
03cf604 
Paparazzi 5.4.0_stable
======================

Stable version release.

- messages: MOVE_WP and WP_MOVED_LLA with altitude in mm
- ins: immediately effective ins_reset_local_origin
- server: don't fail if settings_modules is missing
- python: messagesapp: growable value column width
- python: add python real time plotter to control panel
- module: mavlink, parse PARAM_SET, send origin and waypoints
- module: FLAPS, HATCH, BRAKE via RC in AUTO1
[paparazzi#878] (paparazzi#878)
- fixedwing: use min/max_cruise_throttle variables instead of defines
[paparazzi#1057] (paparazzi#1057)
- GCS: turn off search in flight plan panel to fix hotkeys
[paparazzi#995] (paparazzi#995)
[paparazzi#1061] (paparazzi#1061)
- GCS: fixes for flight plan editor and keeping map center on zoom
[paparazzi#927] (paparazzi#927)
[paparazzi#1059] (paparazzi#1059)
- stm32/luftboot: update libopencm3 to get usb control call back fix
[paparazzi#1058] (paparazzi#1058)

# gpg: Signature made Mo 05 Jan 2015 17:00:28 CET using RSA key ID
4CEDA267
# gpg: Can't check signature: public key not found

Conflicts:
	.gitmodules
	CHANGELOG.md
	conf/Makefile.arm-embedded-toolchain
	conf/Makefile.linux
	conf/Makefile.lpc21
	conf/Makefile.stm32
	conf/airframes/ardrone2_sdk.xml
	conf/airframes/cridea/quad-suave.xml
	conf/airframes/examples/quadrotor_lisa_m_2_pwm_spektrum.xml
	conf/airframes/examples/quadrotor_mlkf.xml
	conf/firmwares/rotorcraft.makefile
	conf/firmwares/rotorcraft.xml
	conf/firmwares/subsystems/shared/imu_aspirin_v2.1.makefile
	conf/firmwares/subsystems/shared/imu_aspirin_v2.1_old.makefile
	conf/firmwares/subsystems/shared/imu_aspirin_v2.2.makefile
	conf/firmwares/subsystems/shared/imu_aspirin_v2_common.makefile
	conf/firmwares/subsystems/shared/imu_px4fmu_v1.7.makefile
	conf/joystick/ms_sidewinder.xml
	conf/messages.xml
	conf/settings/control/stabilization_att_float_quat.xml
	conf/tests_conf.xml
	data/maps/Makefile
	paparazzi_version
	sw/airborne/arch/lpc21/mcu_periph/spi_slave_hs_arch.c
	sw/airborne/arch/stm32/mcu_periph/i2c_arch.c
	sw/airborne/arch/stm32/subsystems/actuators/actuators_pwm_arch.c
	sw/airborne/arch/stm32/subsystems/radio_control/ppm_arch.c
	sw/airborne/boards/ardrone/at_com.h
	sw/airborne/boards/krooz_sd.h
	sw/airborne/firmwares/fixedwing/main_ap.c
	sw/airborne/firmwares/fixedwing/main_fbw.c
	sw/airborne/firmwares/fixedwing/nav.h
	sw/airborne/firmwares/rotorcraft/autopilot.c
	sw/airborne/firmwares/rotorcraft/main.c
	sw/airborne/firmwares/rotorcraft/navigation.h
	sw/airborne/firmwares/rotorcraft/telemetry.h
	sw/airborne/math/pprz_geodetic_int.c
	sw/airborne/math/pprz_geodetic_int.h
	sw/airborne/mcu.c
	sw/airborne/mcu_periph/i2c.c
	sw/airborne/modules/benchmark/flight_benchmark.c
	sw/airborne/modules/cam_control/cam.c
	sw/airborne/modules/ins/imu_chimu.c
	sw/airborne/modules/multi/formation.c
	sw/airborne/modules/multi/potential.c
	sw/airborne/modules/multi/tcas.c
	sw/airborne/modules/sensors/airspeed_ets.c
	sw/airborne/modules/sensors/baro_MS5534A.h
	sw/airborne/modules/sensors/baro_amsys.h
	sw/airborne/modules/sensors/baro_bmp.h
	sw/airborne/modules/sensors/baro_board_module.h
	sw/airborne/modules/sensors/baro_ets.h
	sw/airborne/modules/sensors/baro_ms5611_i2c.h
	sw/airborne/modules/sensors/baro_scp.h
	sw/airborne/peripherals/mpu60x0_i2c.c
	sw/airborne/state.c
	sw/airborne/state.h
	sw/airborne/subsystems/ahrs/ahrs_float_mlkf.c
	sw/airborne/subsystems/datalink/README.md
	sw/airborne/subsystems/datalink/pprzlog_transport.c
	sw/airborne/subsystems/datalink/superbitrf.c
	sw/airborne/subsystems/datalink/superbitrf.h
	sw/airborne/subsystems/datalink/telemetry.c
	sw/airborne/subsystems/datalink/telemetry_common.h
	sw/airborne/subsystems/gps/gps_ardrone2.c
	sw/airborne/subsystems/imu.h
	sw/airborne/subsystems/imu/imu_aspirin_2_spi.c
	sw/airborne/subsystems/imu/imu_drotek_10dof_v2.c
	sw/airborne/subsystems/imu/imu_um6.c
	sw/airborne/subsystems/ins/ins_alt_float.c
	sw/airborne/subsystems/navigation/OSAMNav.c
	sw/airborne/subsystems/navigation/bomb.c
	sw/airborne/subsystems/navigation/poly_survey_adv.c
	sw/airborne/subsystems/navigation/spiral.c
	sw/airborne/test/test_geodetic.c
	sw/ground_segment/tmtc/Makefile
	sw/in_progress/ir_calibration/Makefile
	sw/in_progress/motor_bench/Makefile
	sw/in_progress/satcom/Makefile
	sw/in_progress/wind_tunnel/Makefile
	sw/lib/ocaml/latlong.ml
	sw/logalizer/Makefile
	sw/simulator/nps/nps_ivy_common.c
	sw/supervision/pc_common.ml
	sw/tools/dfu/stm32_mem.py
	tests/examples/01_compile_all_test_targets.t
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GCS
Projects
None yet
Milestone
v5.4
Development

No branches or pull requests
4 participants
@flixr @gautierhattenberger @OpenUAS @alonsoac