improve Papgets with multi aircraft support

[gautierhattenberger]

Makes papgets working with several aircraft. If no target A/C specified, behavior is the same then before.

This will close #181 and a part of #1056

[flixr]

And how do you specify the aircraft id?

[gautierhattenberger]

It is automatic for drag-and-drop.
If you make a papget from a GCS xml file, you just need to add the property to the list. Something like this should work for A/C number 10:

<property name="ac_id" value="10"/>

It reminds me that I should probably save this when using the save GCS layout option... coming soon

[flixr]

Ok, was wondering because you can neither select the ac_id in the papget edit popup, neither was it saved to the config...

[gautierhattenberger]

tested and working with 2 A/C in sim, saving and loading layout

[flixr]

Can you also add the ac_id as an input to the papget edit popup?
On a sidenote: I also noticed that the ticks in the gauge papget are not correctly resized when zooming in.

[gautierhattenberger]

I was wondering if adding the field ac_id to the edit box was really useful. Changing the ac_id dynamically means unbinding and binding again. I did looked at it yet if it is a pain or not, but probably a little.
But I agree that showing the ac_id (without edition) is a good idea. Would it be enough ?

I'll look at the gauge.

[flixr]

I guess at least displaying it (or displaying that any id is used) would be good...

[flixr]

The fix for the gauge papget works nicely, thanks!

Regarding the ac_id for papgets, IMHO it is still not really great and I think we should have at least one of the following options

• upon drag-n-drop of a message: possibility to choose whether it should bind to that specific ac_id or any
  • maybe even default to "any"?
• possibility to disable filtering on ac_id in the papget edit dialog

Otherwise it becomes rather annoying to create a layout that has the papgets you want, but works with any single aircraft.

[gautierhattenberger]

Here, I did option 3: ask if ac_id should be saved or not when saving layout.
The reasons are:

• it is really a annoying to unbind and bind again
• not all papgets have config dialog box
• drag-and-drop to "any" doesn't make mush sense to me
• this solution is easy and covers your main use case

[flixr]

Sounds OK to me :-)

[flixr]

Some remaining things:

• saving the layout removes <!DOCTYPE layout SYSTEM "layout.dtd">
• it asks about saving ac_id even if there are no papgets
• removing a papget doesn't really work, you can drag it out of the map, but it is still there somewhere and saved to the layout...

[gautierhattenberger]

Points 1 and 2 should be okay. For the last one, removing messages papgets works for me (and they are not saved afterwards). For other papgets like buttons, it was not possible to remove them anyway (and I don't plan to do it in this pull request).

[flixr]

Ok, deleting a papget via the popup edit dialog works indeed.
Somehow I was under the impression that you can also remove a papget by dragging it out of the map...
That is not the case, but it would be good if this could be prevented (don't accept the drop if it is outside of the map, or really remove it in that case)...

[gautierhattenberger]

I don't really want to try to find the window size, so it is only deleted on left and top side, which are the places you have to chance get them back. On right and bottom side, you can try to make the window bigger to find your papget again...

[flixr]

Would have been nice to somehow get the map window size where you can place papgets.
But I guess this is good enough for now and there are more important problems to work on...

[gautierhattenberger]

Found it ;)

[flixr]

nice :-)
Works and looks good to merge to me...