Dual dual pwm #1102
Dual dual pwm #1102
Conversation
| @@ -153,13 +154,13 @@ void dual_pwm_isr(void) | |||
| if (num_pulse == 1) { | |||
|
|
|||
| set_dual_pwm_timer_s_period(ratio_16ms); | |||
| set_dual_pwm_timer_s_oc(actuators_dualpwm_values[FIRST_DUAL_PWM_SERVO]); | |||
| set_dual_pwm_timer_s_oc(actuators_dualpwm_values[2],actuators_dualpwm_values[4]); | |||
There was a problem hiding this comment.
Seems to be hardcoded now... probably not what we want...
If you really want to keep it hardcoded, at least remove the FIRST_DUAL_PWM_SERVO and SECOND_DUAL_PWM_SERVO defines...
|
changed This should better indicate that the dualpwm pulse comes out of lisa-s servo marked Unfortunately it is currently not possible to put this defines for servo channels in your airframe file: see #1108 So one should lookup in 'lisa-s.h' that index 0 and 1 pulses come out of servo5 and index 2 and 3 pulses come out of servo6 |
| @@ -0,0 +1,276 @@ | |||
| <!-- this is a LadyBird quadrotor frame equiped with Lisa/S 1.0 --> | |||
There was a problem hiding this comment.
guess it would make sense to provide proper description here (at least remove the ladybird stuff that is not correct)
|
What about the |
|
|
|
I meant the lisa_m_common.h file which still has the old defines... |
|
Does anybody know where the |
|
Seems they were added with #678, no idea if they were actually ever used on LisaM... |
|
Could you plz update the description in DelFlyDualPWMservo.xml, otherwise it looks good to merge to me... |
developments that should eventually make it to master...