-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry settings #118
Telemetry settings #118
Conversation
settings list and the GCS (working with fixedwing and rotorcraft firmwares)
@@ -113,7 +142,9 @@ let _ = | |||
fprintf avr_h "/* This file has been generated from %s and %s */\n" Sys.argv.(2) Sys.argv.(3); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please rename avr_h to something more appropriate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do
I like it :-) First step to making settings easier to use. While we are at it: I think it would be nice to rename periodic.h to something more accurate. When I read #include "generated/periodic.h", periodic telemetry messages are not the first thing that come to mind... telemetry_booz2.xml should be renamed to telemetry_rotorcraft.xml And now that keyboard shortcuts are directly specified in the telemetry file and most people will just "have" them, I wonder what happens if the same key is given twice for two different settings? |
most of the people already have the shortcut keys without knowing as they use the standard settings file. It just moves the definition of the key. |
I know that most people already have the shortcut keys, just wondering what happens if you have the same shortcut for multiple settings...
good
At some point that was explicitly added (by antoine?) because it was supposed to be more clear what the file was...
What do you mean by backward compatibility in this case?
Sure, do it in a new branch based on dev, when it works, merge it back to dev.... Then soon we will have to merge dev back to master anyway and announce all the relevant changes (e.g. the automatic unit conversions, etc. ) and document that on the wiki. When we do that we just make version tags as well. |
Just as a side note, I would like to reuse some of the CSC code on Lisa/M as it can be used in the same fashion but CSC itself can be dropped in my opinion. |
Sure, I deleted all the csc stuff in the dev branch already... but it's not like it's totally gone ;-) |
OK as long as I can find it when I want to resurrect it... :) |
git log --grep csc On Wed, Jan 25, 2012 at 7:21 PM, Piotr Esden-Tempski
|
…ode generation (unused)
Conflicts: sw/airborne/firmwares/rotorcraft/telemetry.h
Should we merge this now? |
What do you want to clean ? source code or config files ? |
I meant the telemetry xml files. |
@flixr do you know if it is possible to change the pull request range (to merge in 4.0 rather than dev) without closing and opening again ? |
@gautierhattenberger I don't think that is possible. Also the conf/conf.xml.example probably needs to be adjusted to reflect the new names for the telemetry files... |
The pull request is merged in the 4.0_beta branch and is now closed (no merge in dev branch) |
Tthe settings for the telemetry modes are automatically generated from the XML file and are available in the GCS.
Old settings file are updated.
Fixedwing and rotorcraft firmewares are supported (not csc (obsolote ?) nor fms test program).