[logalizer] rename plot to logplotter for clarity #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 from me! 😄 |
|
@gautierhattenberger what do you think? |
|
Can we put a placeholder in that place instead, that prints out an error indicating the name change and what needs to be done? |
|
Done, if launched via the old |
|
@gautierhattenberger any comments? |
|
Fine for me |
flixr
added a commit
that referenced
this pull request
Jul 14, 2015
[logalizer] rename plot to logplotter for clarity Was quite unclear that plot refers to the log plotter and plotter to the realtime plotter... Hence rename the plot executable to logplotter. If launched via the old plot it will print that plot was renamed to logplotter and then launch logplotter.
|
@flixr the usage message needs to be updated apropo: It still says |
|
Thx, fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was quite unclear that
plotrefers to the log plotter andplotterto the realtime plotter...Hence rename the
plotexecutable tologplotter