Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPS] Implement smaller GPS messages from NATNET to PPRZ #1308

Closed

Conversation

LodewijkSikkel
Copy link
Contributor

I made a number of changes to the natnet client and gps_datalink files such that it is possible to send all the required GPS information (for flying in the Optitrack arena) within 10 bytes.

@flixr
Copy link
Member

flixr commented Aug 19, 2015

The airframe file you added uses a different mixing than the example bebop, would make sense to use the same...
Also this here includes some changes for the bluegiga, which is currently handled in the separate PR #1303
Can you plz also run sw/airborne/subsystems/gps/gps_datalink.c through fix_code_style.sh ?

@LodewijkSikkel
Copy link
Contributor Author

I was a bit too hasty in pushing this request, will fix everything and resubmit

@LodewijkSikkel
Copy link
Contributor Author

I forgot to include a file, will push the latest version shortly

struct LlaCoor_i lla_pos;
#endif

bool_t gps_available; ///< Is set to TRUE when a new REMOTE_GPS packet is received and parsed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be removed, not used anywhere...

@flixr
Copy link
Member

flixr commented Aug 31, 2015

@LodewijkSikkel any updates here?

@LodewijkSikkel
Copy link
Contributor Author

yes but there were some bugs

On 31 Aug 2015, at 23:46, Felix Ruess <notifications@github.commailto:notifications@github.com> wrote:

@LodewijkSikkelhttps://github.com/LodewijkSikkel any updates here?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1308#issuecomment-136510417.

@LodewijkSikkel
Copy link
Contributor Author

okay it should be fixed, we test flew it today and everything seems to work properly

@flixr
Copy link
Member

flixr commented Sep 2, 2015

The format of the REMOTE_GPS_SMALL is still not clear from the messages description...
Would be nice if you could add that....

@flixr flixr closed this in 1cac358 Sep 2, 2015
@LodewijkSikkel
Copy link
Contributor Author

How would I add that the first 10 bits are the x position, the next 10 the y position and so on...

It is stated in the code though..

@flixr
Copy link
Member

flixr commented Sep 2, 2015

Write it in the description of the message or the field?
See e.g. https://github.com/paparazzi/paparazzi/blob/master/conf/messages.xml#L274

@LodewijkSikkel
Copy link
Contributor Author

Ah okay

@LodewijkSikkel
Copy link
Contributor Author

I changed it, do I need to make a new pull request?

@flixr
Copy link
Member

flixr commented Sep 2, 2015

THX.... I'll just cherry pick it when I get home...
Am 02.09.2015 8:22 nachm. schrieb "LodewijkSikkel" <notifications@github.com

:

I changed it, do I need to make a new pull request?


Reply to this email directly or view it on GitHub
#1308 (comment).

@flixr
Copy link
Member

flixr commented Sep 2, 2015

cherry picked updated descriptions with 6d696b2

@flixr flixr added this to the v5.8 milestone Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants