Follow me based on stereo camera #1473
Conversation
| * | ||
| */ | ||
| /** | ||
| * @file "modules/follow_me/follow_me.c" |
|
it looks like the follow_me module is in two pull request with different names, which one should be kept ? |
|
This one should be kept. I believe I fixed all comments right now. Let me know if there are more requests. |
| * | ||
| */ | ||
| /** | ||
| * @file "modules/stereocam/stereocam_follow_me/stereocam_follow_me.h" |
|
Can you add a few more lines to describe the module and merge/solve conflicts with paparazzi/master ? Beside that it is okay for me |
|
Added a short description and removed the quotes! |
Follow me based on stereo camera
|
You did more than that.... added a |
|
Why do we have that message now? |
|
since it was only TUDelft stuff I assumed they were okay with the changes. If it is not the case, @rmeertens can you provide a valid conf in a new pull request ? |
|
That message is not used anywhere... Please try to only include changes relevant to that specific pull request... check again before you push... |
|
Welp, sorry guys. Looks like I already pushed the message of a module I planned to push to master next week :s next time I will also rebase. Is it ok for now to leave the message in although the module that uses it will be pushed next week? |
|
I'll remove that accidentally added stuff for now. Also please try to document all options in the module xml (like |
|
Will document it in the next push to master. What message would you like to use? Currently I plot the velocities in this message, and the velocities of optitrack to be able to compare them. I would like to keep the distinction between for example this measurement and the fused INS message. |
|
I think it would be nice if we added a slightly more generic message that basically reports a velocity estimate (e.g. also from optic flow or px4flow). |
Last thing I want to add today: a follow algorithm that uses our stereo camera module.
Just tested an demonstrated it, whoo.