[gps] add fields_valid and remove GPS_USE_LATLONG #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add fields_valid bitfiled to gps struct and use that to decide whether a valid UTM pos is availabe instead of always computing UTM if GPS_USE_LATLONG is defined should close #641
|
Loving this Felix! |
|
Tests to confirm all is still working as expected would be appreciated, I could only test the sim... |
|
This is a really nice change, but except testing some ublox module in the lab, I won't be able to do more before leaving for vacations. It doesn't really change much for end-users and it may have some side effects if we missed some stupid bugs, so maybe it is not wise for a stable release... |
|
Agreed, waiting for after the release... |
flixr
added a commit
that referenced
this pull request
Dec 21, 2015
[gps] add fields_valid and remove GPS_USE_LATLONG add fields_valid bitfiled to gps struct and use that to decide whether a valid UTM pos is availabe instead of always computing UTM if GPS_USE_LATLONG is defined
gautierhattenberger
added a commit
that referenced
this pull request
Dec 27, 2015
- was correctly used for init but not normal reading - add convenience function to get utm from GPS struct fix stuff missed in #1476
flixr
added a commit
that referenced
this pull request
Dec 28, 2015
- add convenience function to get utm in int from GPS struct fix stuff missed in #1476
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add fields_valid bitfiled to gps struct and use that to decide whether a valid UTM pos is availabe instead of always computing UTM if GPS_USE_LATLONG is defined
should close #641