[gps_datalink] update small message protocol #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks basically good to me, like that you got rid of USE_DATALINK_SMALL ;-) Some comments inline in the changes... |
| @@ -27,35 +27,19 @@ | |||
| * GPS structure to the values received. | |||
| */ | |||
|
|
|||
| #include "messages.h" | |||
| #include "generated/airframe.h" // AC_ID | |||
There was a problem hiding this comment.
AC_ID doesn't seem to be used in this file...
|
No prob with the separate define for alt and alt_speed but do I really have to add the settings for the noise? Not so interesting for me. Can I just make a comment that it is a todo? I assume you can also do that for the sonar... |
|
I didn't mean settings for the noise, but rather make the update of alt and vel not only configurable via a define, but via a runtime variable... |
gautierhattenberger
added a commit
that referenced
this pull request
Jan 11, 2016
[gps_datalink] update small message protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed USE_DATALINK_SMALL definition. Local reference frame now initialized from flight plan.
Updated flight plans that used USE_DATALINK_SMALL.
Added z speed and higher resolution heading to message.
Added gps z speed to ins vertical filer.
Ran fix_code_style on natnet2ivy.c.