[refactor] add shared datalink for all firmware #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice :-) Apart from the missing declarations it would probably make sense to rename the firmware specific |
|
ah yea, forgot to include the datalink.h. Isn't it enough that the files are in their respective firmware folders? If not let me know and I will rename them. |
kirkscheper
force-pushed
the
refactor_datalink
branch
from
93975bc
to
57697b4
Compare
|
IMHO it is cleaner if files that are meant to be compiled together have unique names... |
[refactor] add shared datalink for all firmware [refactor] add shared datalink for all firmware [refactor] add shared datalink for all firmware
kirkscheper
force-pushed
the
refactor_datalink
branch
from
57697b4
to
10c4af0
Compare
|
done |
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to help the joining of fixedwing and rotorcraft. This way all shared datalink code and updates only have to be done once. Firmware specific code not yet shared can be kept separate in the original files.
Pull request also contains a start for drone to drone messaging but reading the messages is waiting for the dl macros in telemetry.