-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ext] update to latest libopencm3 #1557
Conversation
This does not compile for me... arch/stm32/mcu_arch.c:44:48: error: 'RCC_CLOCK_3V3_END' undeclared here (not in a function) ...... |
@kevin: was this not our clock setup code for the 24MHz crystal? Probably
|
I tried it with a clean master on the Logo600 airframe. Should not have anything to do with PX4 config. |
@kevindehecker then you didn't call toplevel make first, it needs to fetch the updated submodule and recompile the libopencm3 libs... |
Nop, did that to. However, I first commited after the cherry-pick because of that submodule nonsense ( it reported uncommited changes for the submodule). Maybe that was something I was not supposed to do... |
you probably changed the submodule back to the previous version or so... |
Apparently I did... Managed to compile the AP for my Iris. Next problem; after uploading the AP, ttyACM0 does not show up anymore (or any other new tty device for that matter)... Sys time led is going strong though, so the AP seems to run fine. |
hm... so there must have been some changes in libopencm3 that make this silently not work anymore. |
So transparent_usb telemetry still works fine on my LisaMX. Other things are working fine though? Are you sure the clock setup is correct in your case? |
It's on the F4, so the clock config should be fairly standard. I'm however not using telemetry over usb though (and as such did not set transparant_usb), but using usb serial directly from a module. Which works with the current libopencm3, but apparently not with this newest version. |
transparent_usb uses the same usb serial code, so it shouldn't really make a difference... (except maybe where/when you call send_message in your module?). |
OK, also transparant_usb is not working. No /dev/ttyACM device appears. |
Think I may have found something, the new libopencm contains another clock config (84MHz), which is not implemented in the pprz version of the 24 ext crystal function... |
.ahb_frequency = 48000000, | ||
.apb1_frequency = 12000000, | ||
.apb2_frequency = 24000000, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, there should be another 84MHz config here! That solves my problem.
and update clock setup accordingly
Rebased, added missing 84MHz entry and updated F1 24MHz setup accordingly as well... |
@kevindehecker just to clarify: what is working for you now? You get a device again, but is the px4io flashing working now as well, or same problem as before the libopencm3 update? |
Yes, the device works, but unfortunately the new libopencm3 does not solve my PX4 usb flashing problem :(. |
Bummer... but I think it would be good to merge this anyway. |
Yes please merge. I will work on a clean usb issue Monday. |
@gautierhattenberger any objections in merging this? |
Seems to work on Apogee with and without ChibiOS mix. |
[ext] update to latest libopencm3
and update clock setup accordingly