Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bebop camera luminosity increase. #1562

Merged
merged 1 commit into from Mar 23, 2016
Merged

Bebop camera luminosity increase. #1562

merged 1 commit into from Mar 23, 2016

Conversation

Pax1601
Copy link
Contributor

@Pax1601 Pax1601 commented Mar 10, 2016

Using the datasheet of the Bebop front camera, I've edited the video.c source code to increase the gains and obtain a better image.

Using the datasheet of the Bebop front camera, I've edited the video.c source code to increase the gains and obtain a better image.
@flixr
Copy link
Member

flixr commented Mar 10, 2016

Sounds good to me :-)
Is the gain always fixed? Only shutter time is adjusted dynamically?
@gautierhattenberger @fvantienen & co.
Could anyone else with a Bebop please test this as well?

@Pax1601
Copy link
Contributor Author

Pax1601 commented Mar 10, 2016

It is my understanding that both the shutter time and the gains are completely fixed (right now). I've modified the values of the gains so that it can work indoors. A better idea would be to allow the user to define the gains, maybe with different presets, for indoors and outdoors usage. These values are a bit too high for outdoors use, but I believe they are better overall.

@dewagter
Copy link
Member

Shutter time and white balance are not automatic on the bebop front camera
but must be adjusted by user code.
Another commit is expected which will process the image in the ISP which
also returns histograms to adjust both from user space.

In the mean time it's OK for me to adjust the shutter time to indoor
conditions. Even better would be to create a setting that can be adjusted
with a slider from the GCS and saved:

Settings:

LUM: auto (not supported yet) - manual
Shutter - slider

AWB: auto (not supported yet) - manual
Red - slider
Green - slider
Blue - slider

-Christophe

On Thu, Mar 10, 2016 at 3:52 PM, Pax1601 notifications@github.com wrote:

It is my understanding that both the shutter time and the gains are
completely fixed (right now). I've modified the values of the gains so that
it can work indoors. A better idea would be to allow the user to define the
gains, maybe with different presets, for indoors and outdoors usage. These
values are a bit too high for outdoors use, but I believe they are better
overall.


Reply to this email directly or view it on GitHub
#1562 (comment).

@OpenUAS
Copy link
Contributor

OpenUAS commented Mar 22, 2016

A merge as interim solution maybe... @Pax1601 thx for you great work done, the frontcam datasheet is quite a hefty amount of pages...

@flixr flixr merged commit badb2ba into paparazzi:master Mar 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants