Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed default gcs layout #1600

Merged
merged 1 commit into from Jun 20, 2016

Conversation

EwoudSmeur
Copy link
Member

Working with the GCS has always been a bit painful for me, particularly because of 1 reason: the layout. The settings panel is always too small, and the map is always too wide (unless you really like flying east-west). Dragging the panels around is annoying and time consuming.

But I learned something recently, apparently there are other layouts! The large_left_col has the same panels, but then with a more square map and a wide settings panel. I think this is great for everyone, so I suggest making it the default

@EwoudSmeur
Copy link
Member Author

As I mentioned, I think this is something everyone should benefit from, because of the reasons I mention above. If there are reasons why the horizontal layout is preferred by a majority of paparazzi users, I will happily change it in my own control panel.

@flixr
Copy link
Member

flixr commented Apr 18, 2016

I have no strong feelings about the default...

@podhrmic
Copy link
Member

FYI We are using this layout:
screenshot from 2016-04-18 12 29 45

My guess is that everyone likes something different so no strong opinion about the default option either.

@gautierhattenberger
Copy link
Member

I'm also using a custom version of the default layout, and different from the one above. One remark against changing it is that the documentation and wiki examples are build upon the historical layout.

@dewagter
Copy link
Member

Is there a way to set the layout when starting replay/sim. The lines below
do not work for me:

<program name="GCS" command="sw/ground_segment/cockpit/gcs">
  <arg flag="-layout" constant="bottom_settings.xml" />
</program>

-Christophe

On Tue, Apr 19, 2016 at 12:20 AM, Gautier Hattenberger <
notifications@github.com> wrote:

I'm also using a custom version of the default layout, and different from
the one above. One remark against changing it is that the documentation and
wiki examples are build upon the historical layout.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#1600 (comment)

@EwoudSmeur
Copy link
Member Author

I am thinking about new users here. Of course you can modify and fiddle with all the settings, but I think you can not expect a new user to do this when he is starting out.

So I think we have the possibility to make something that already works nice out of the box, and can still be modified to your own needs. That is why I care about the defaults.

Indeed I can change the settings for myself, and I actually just did. So for myself, I don't care if you close this pull request. But instead of saying: why don't you just do what you want and I do what I want; maybe we should be saying, what do other (less experienced) people want?
Cheers

@flixr
Copy link
Member

flixr commented Apr 21, 2016

I actually also prefer layouts with strip on the side and settings at the bottom (especially since scrolling in settings is annoying).
In any case I'm fine with either default (pro keeping the one we have is IMHO mostly(only?) the already existing docs/images).

@EwoudSmeur
Copy link
Member Author

So far I only heard people say something like 'why change the default, by the way I am using something other than the default'. I think this is a good reason to change it.

Regarding the wiki issue, Since the same panels are there, just at a different location, I think there will be very little confusion...

@gautierhattenberger
Copy link
Member

The point was: we all use different defaults...
There is probably a way to store an alternate default for the GCS (in the %gconf.xml file that stores latest user parameters)

@EwoudSmeur
Copy link
Member Author

No, the point is: none of you is using the default, you all use custom settings.

I am not sure how I can make my point clearer... This is not about me, I know how to change it. It is about other users then me, the ones that will use the default when they start out.

And if you use something else, you are NOT using the default.

@gautierhattenberger
Copy link
Member

I perfectly understand what your saying, but it is hard to find the "best" default since everyone is using a different custom layout. So changing it will not change anything for you, for me or most of the other dev members.
So, if their is something to improve, I would say it is make it easier for new users to change the layout and eventually set one by default, while keeping the hard-coded fallback because we need one at some point.

@kevindehecker
Copy link
Contributor

  1. I would not say the goal here is to find the best layout... but just a better one. In principle, having a squared map is better. Also, the settings are very often used, and currently by default you need to scroll always making it quite painfull. So, here the proposed layout is also better. (meaning in general, etc etc)
  2. The argument of not improving something because ...the documentation may need some work, is quite pitiful.
  3. We are having a lot of new users (students), and we are very often helping them with problems. They all use the unhandy default. Eventually this makes our lifes difficult as well, even though we have changed the default layout ages ago...

For these reasons, but mostly 3), I am in favor of improving the default layout to something better.

@flixr
Copy link
Member

flixr commented May 15, 2016

@dewagter adding the layout in control_panel.xml as you wrote works fine for me...

Also I'm fine with changing the default, but ideally we would make it easier to save the preferred layout in %gconf.xml like @gautierhattenberger already said.

@flixr
Copy link
Member

flixr commented May 18, 2016

@gautierhattenberger do you want to implement something to make changing/remembering the layout easier?
Or do we use #1671?
We could also just change it in the control_panel_example.xml file, so that new users will get the layout argument appended instead of changing the hardcoded default...

Either way is fine with me, but I like this layout better (although I normally use a modified version of left_col) than the current default.

@gautierhattenberger
Copy link
Member

I actually like the solution of #1671, it both allow to remember your setting (even after make clean) and can be shared with others when providing a control panel file (like giving pre-configured control panel to student).
The only thing I would like to have someday is the possibility to dynamically change the layout, be that would be for an other day...

@flixr
Copy link
Member

flixr commented May 20, 2016

So do we change the hardcoded default or only set <arg flag="-layout" constant="large_left_col.xml" /> in control_panel_example.xml?

@EwoudSmeur
Copy link
Member Author

I am very much fine with that. Though then we might as well change the default too

@flixr
Copy link
Member

flixr commented May 24, 2016

@gautierhattenberger @martinmm what do you prefer?

  1. change hardcoded default
  2. add default layout arg in control_panel_example.xml
  3. both

flixr added a commit that referenced this pull request May 24, 2016
@flixr
Copy link
Member

flixr commented Jun 20, 2016

@gautierhattenberger So, should we also change the default that is hardcoded in gcs?
Or do we close this?
Fine with me either way...

@gautierhattenberger
Copy link
Member

After think again about this, I think I mostly liked the current because I'm used to it and it was well balanced when it was made (with less buttons and settings). Maybe it is not the case anymore.
So let's put an end to this, because it really doesn't matter after all.

@gautierhattenberger gautierhattenberger merged commit 210e392 into paparazzi:master Jun 20, 2016
wilcoschoneveld pushed a commit to wilcoschoneveld/paparazzi that referenced this pull request Jun 22, 2016
@EwoudSmeur EwoudSmeur deleted the gcs_layout branch August 5, 2016 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants