Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modules] Add OPA controller #1657

Merged
merged 2 commits into from
May 12, 2016

Conversation

fvantienen
Copy link
Member

Special controller for the OPA (Oversized paparazzi Autopilot), which enables the full functionally of the the board.
This includes:

  • Power of AP from FBW
  • Power of Motor from FBW
  • Power of Charging of FBW battery from FBW
  • Disabling power of Motor from AP settings trough FBW
  • Power of Vision computer trough AP

@podhrmic
Copy link
Member

podhrmic commented May 6, 2016

@fvantienen did you add the hardware source files (schematics and layout) of the board into pprz-hardware repo? Because otherwise it is not very useful to have support for a board other people cannot get/make/use...

@fvantienen
Copy link
Member Author

Not yet, this board is specifically made for the Outback challenge 2016. Even if we share it probably no one is going to use it.
Nevertheless we want to have it in master, else we always have to redo a lot of work if someone updates something this is depending on. Eventually we want to fly the challenge on the latest master.

@gautierhattenberger
Copy link
Member

It looks fine for me. Since you are now using a cmd_status bit mask, maybe documenting it and add some macros (at least bit shift) to access each elements.

@podhrmic
Copy link
Member

podhrmic commented May 6, 2016

That is understandable, but maybe somebody can benefit from the design you made and use it for some other competition / application. Otherwise it sets a precedent and people will start uploading their custom boards that are not useful and just clutter the repository. So I would really appreciate if you shared it.

@podhrmic
Copy link
Member

podhrmic commented May 7, 2016

@esden what do you think?

@fvantienen
Copy link
Member Author

fvantienen commented May 7, 2016

I'm not the one who designed it.. so it's not my decision. It's @dewagter.
Next to that the board is still in the Alpha stage.. and not even close to a release..

But if these things not get merged I don't think Paparazzi will get any updates from the Outback anymore, because I don't like to backport everything. So also useful stuff I will then not spend anymore time on to backport it to master, and we will then fly with our own branch of Paparazzi which is never going to get merged.
So for me it is either everything or nothing...

We want to fly with master, so that our other more useful developments are also in there. If that is not possible because of missing modules/boards we specifically designed for the Outback, we will then also do all are developments of useful stuff on another branch.

@dewagter
Copy link
Member

dewagter commented May 8, 2016

The board for outback is actually 2x lisa-mx on a single PCB, with a lot of
power control (including self-power-down), line drivers, ESD protection,
temperature, rpm & current sensing, logging, backup IMU etc. Any pin from
Lisa-MX is kept the same (which is why this pull request is so small by
reusing mx defines), but many power options are added (e.g. self-power-on).

Most power options (like EStop, Arming, Off) are requirements from the
outback challenge. I expect those to be needed for many more years and even
other boards. And the power control uses defines so if the power control
hardware is added to/beside other autopilots, it should be directly usable
already.

-Christophe

On Sun, May 8, 2016 at 12:24 AM, Freek van Tienen notifications@github.com
wrote:

I'm not the one who designed it.. so it's not my decision @dewagter
https://github.com/dewagter.
But if these things not get merged I don't think Paparazzi will get any
updates from the Outback anymore, because I don't like to backport
everything. So also useful stuff I will then not spend anymore time on to
backport it to master, and we will then fly with our own branch of
Paparazzi which is never going to get merged.
So for me it is either everything or nothing...


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1657 (comment)

@fvantienen
Copy link
Member Author

I added the dox ;)

@fvantienen
Copy link
Member Author

@gautierhattenberger or @flixr can we merge this?

@gautierhattenberger gautierhattenberger merged commit 522c73d into paparazzi:master May 12, 2016
@fvantienen fvantienen deleted the opa_controller branch May 12, 2016 09:43
@flixr
Copy link
Member

flixr commented May 15, 2016

Please always add all define/configure options in the documentation section of the module xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants