Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] increase quat size to avoid overflow #1722

Merged
merged 1 commit into from
Jun 14, 2016

Conversation

kirkscheper
Copy link
Member

original rotation would overflow for some rotations. I extended the variable size to ensure it all fits. Simple fix.

@flixr
Copy link
Member

flixr commented Jun 14, 2016

Thx!

You don't by any chance want to extend the math unit tests to cover things like this?
See tests/math/test_pprz_math.c, etc

@kirkscheper
Copy link
Member Author

Sneaky sneaky Felix. Yea, no prob, will do.

Kirk
On 14 Jun 2016 7:07 p.m., "Felix Ruess" notifications@github.com wrote:

Thx!

You don't by any chance want to extend the math unit tests to cover things
like this?
See tests/math/test_pprz_math.c, etc
https://github.com/paparazzi/paparazzi/tree/master/tests/math


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1722 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ACtEQ-yE-GwN-B22iJvZwYg8JufU0hyhks5qLt_egaJpZM4I1hZU
.

@flixr
Copy link
Member

flixr commented Jun 14, 2016

Merging this already...
but having more unit tests for the math lib, state interface, etc... would be really great!
Any additional tests there will be greatly appreciated!

@flixr flixr merged commit 514a74b into paparazzi:master Jun 14, 2016
@kirkscheper kirkscheper deleted the overflow_fix branch June 20, 2016 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants