Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filters] delayed first order filter int #1736

Merged
merged 9 commits into from
Jun 19, 2016

Conversation

bartslinger
Copy link
Contributor

This is a integer implementation of a first-order filter, with some extra's:

  • saturation on increment rate
  • delay using a buffer

I use this for an INDI implementation for a helicopter, which will follow later in a pull-request.

@flixr
Copy link
Member

flixr commented Jun 17, 2016

Since this seems to be useful for other things as well, it would make sense to choose a more generic name than "heli_rate_filter"...
And maybe make the frequency a parameter instead of using the fixed PERIODIC_FREQUENCY

Out of curiosity: why do you want the delay?

@bartslinger
Copy link
Contributor Author

Do you have a suggestion for the name? I can change the frequency to parameter if you like. I need delay because I use this filter also to make a model of the actuator, which responds +- 18ms after a command is applied. This gives me the estimated position of the actuator.

@flixr
Copy link
Member

flixr commented Jun 17, 2016

Puh... maybe something like delayed_low_pass or so??

@bartslinger
Copy link
Contributor Author

What do you think of fancy_first_order_lowpass?

@flixr
Copy link
Member

flixr commented Jun 17, 2016

lol, then probably rather delayed_first_order_lowpass or something else that describes the functionality...

@bartslinger
Copy link
Contributor Author

Ok I'll go for that

@bartslinger
Copy link
Contributor Author

bartslinger commented Jun 17, 2016

Done. Oh wait the heli rate filter thing is still there.

@bartslinger
Copy link
Contributor Author

Done? :-p

@bartslinger bartslinger changed the title Heli rate filter pr [filters] delayed first order filter int Jun 18, 2016
@gautierhattenberger
Copy link
Member

looks good to me

@flixr
Copy link
Member

flixr commented Jun 19, 2016

@bartslinger We could still give the struct and functions shorter (e.g. abbreviated) names if you want...
But if you are also happy with the long names we can merge it as it is now.

@bartslinger
Copy link
Contributor Author

I'll leave it like this for now. Then I continue with my next PR ;-)

@flixr flixr merged commit 4531e57 into paparazzi:master Jun 19, 2016
@bartslinger bartslinger deleted the heli_rate_filter_pr branch June 21, 2016 20:59
wilcoschoneveld pushed a commit to wilcoschoneveld/paparazzi that referenced this pull request Jun 22, 2016
This is a integer implementation of a first-order filter, with some extras:
- saturation on increment rate
- delay using a buffer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants