Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chibios] split FBW and AP threads #1767

Merged
merged 3 commits into from
Jun 27, 2016
Merged

[chibios] split FBW and AP threads #1767

merged 3 commits into from
Jun 27, 2016

Conversation

gautierhattenberger
Copy link
Member

  • add protection on ap and fbw state structures
  • add RTOS abstraction macros
  • update closing of ap/fbw threads with sdlog

- add protection on ap and fbw state structures
- add RTOS abstraction macros
- update closing of ap/fbw threads with sdlog
@flixr
Copy link
Member

flixr commented Jun 27, 2016

Looks mostly good to me, just one thing regarding naming:
Strictly speaking mutexes are not RTOS functionality. E.g. under Linux (non-RT OS, at least without patches) we use the pthreads mutexes.
So maybe simply rename the macros to PPRZ_MUTEX_*?

Also before we add a lot to the old fixedwing intermcu: what is the path to common usage of the "new" subsystems/intermcu @fvantienen ?

@gautierhattenberger
Copy link
Member Author

Do you have an idea about how to rename pprz_rtos.h ?

The intermcu subsystem seems to be very specific to PX4 boards and clones. Not sure it can fit in the fixedwing firmware easily.

@fvantienen
Copy link
Member

It should not be specific for PX4, there is just some code in there for that that needs to be moved out. We mostly use it with the OPA autopilot (which basically is two lisa/mx's).
The new subsystem intermcu seems the way to go except that it could be converted to a module.

@flixr
Copy link
Member

flixr commented Jun 27, 2016

So what is missing to use it for fixedwing firmware?

@flixr
Copy link
Member

flixr commented Jun 27, 2016

see also #1771

@gautierhattenberger
Copy link
Member Author

It can probably work on without to much effort as long as you have a physical link (uart in this case), but it is currently not really fitted for shared memory operation (mostly based on pprzlink).
So what should I do for this PR ? I won't have the time to do much more than this at the moment.
At some point, I'll have to port the chibios arch for rotorcraft as well, so I may have a look at how to merge intermcu stuff at this time.

@flixr
Copy link
Member

flixr commented Jun 27, 2016

Ok, so let's merge this as it is now.
But we should really follow up on a unified inter_mcu in #1771

@flixr flixr merged commit 451ff35 into master Jun 27, 2016
@flixr flixr deleted the fbw_thread branch June 27, 2016 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants