[imu] convert imu subsystems to modules #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gautierhattenberger any ideas on the recursive autoload problem? |
|
regarding the settings (basically body_to_imu), it is possible to reference a file, but then generated doc is not as informative. Otherwise, a common imu module seems a good idea. |
gautierhattenberger
force-pushed
the
imu_modules
branch
from
4f418e3
to
f94246e
Compare
flixr
force-pushed
the
imu_modules
branch
2 times, most recently
from
2bcbc97
to
2bbc502
Compare
|
Tested and working on Apogee. |
|
IMU on Ardrone2 should be fixed, although I can't test that... |
Also - get rid of explicit imu init|event|periodic calls in main - each imu implementation has their own imu_x_init/event/periodic
and put body_to_imu settings in imu_common module
|
@gautierhattenberger @kirkscheper @fvantienen or anyone else interested: |
|
@podhrmic @gautierhattenberger any more tests/comments here? |
|
OK, so I did some tests. First of all, if I start GCS I get these errors: So that probably should be fixed... Otherwise:
|
|
Thanks for testing. Sounds like you were you using your own outdated conf.xml. |
podhrmic
pushed a commit
to podhrmic/paparazzi
that referenced
this pull request
Sep 16, 2016
* [imu] convert imu subsystems to modules Also - get rid of explicit imu init|event|periodic calls in main - each imu implementation has their own imu_x_init/event/periodic * [imu] fix some imu modules * [imu] fix bad paths * [imu] add imu_common module that every implementation autoloads and put body_to_imu settings in imu_common module * [imu] fix imu_ardrone2 * [conf] add imu_common settings module in conf_example and conf_tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also
Reviews and tests appreciated!
TODO:
imu_lisa_m_v2.1works, but notimu_lisa_mx_v2.1which is just intended as an alias and autoloadsimu_lisa_m_v2.1(fixed with 1973131)should we really keep this orupdate the failing LPC airframes to explicitly set the devices?