Added cv_detect_contour module #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| extern float contour_d_x, contour_d_y, contour_d_z; | ||
|
|
||
| // values for thresholding the contour | ||
| extern int lower_y, upper_y, lower_u, upper_u, lower_v, upper_v; |
There was a problem hiding this comment.
these should probably be either passed as args to find_contour or at least grouped in a struct to not pollute the whole namespace with these rather generic names...
|
IMHO same goes for the whole contour result stuff... |
|
Done! |
| extern float contour_d_x, contour_d_y, contour_d_z; | ||
| struct contour_estimation{ | ||
|
|
||
| float contour_d_x, contour_d_y, contour_d_z; |
There was a problem hiding this comment.
please fix indentation in this file...
Closed
|
Nice! Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revamped #1785
Now it works, code looks nice, no warnings and actually compiles.