Spektrum rewrite #1799
Spektrum rewrite #1799
Conversation
| @@ -109,7 +109,7 @@ let write_settings = fun xml_file out_set telemetry_xml -> | |||
| fprintf out_set "<!-- This file has been generated by gen_periodic from %s -->\n" xml_file; | |||
| fprintf out_set "<!-- Version %s -->\n" (Env.get_paparazzi_version ()); | |||
| fprintf out_set "<!-- Please DO NOT EDIT -->\n\n"; | |||
| fprintf out_set "<settings>\n"; | |||
| fprintf out_set "<settings target=\"ap|nps\">\n"; | |||
There was a problem hiding this comment.
See the general comment ;) this is btw true, since there is no telemetry in fbw.
There was a problem hiding this comment.
not quite, fixedwing fbw has telemetry, also other targets like tests and maybe some loggers do...
|
How are the fbw and intermcu_init changes related to the new spektrum parser? |
|
Yeah those should be removed here.. but I tested this in a FBW+AP setup. And wanted to try to get settings to work in the FBW(because there this module runs). But this caused other problems with the GCS part not able to set the FBW settings(which I wanted to set through intermcu). So all that changes can be removed and are non important for this PR. But I just rebased this branch to master and didn't spend time removing these parts yet. |
|
@fvantienen any updates here? Can you fix the merge conflicts? |
|
Would like to see this great and warm welcomed improvement merge a reality so: This I can fix:
Maybe @kevindehecker can help since he was busy with spektrum bind code a lot for Pixhawk so these:
Maybe @flixr this one?
and maybe you cold add this yourself?
Then we can:
|
|
As @fvantienen will be available again as of ~20180629 well go through this one |
|
Since @fvantienen will be available again as of ~20180629 we will be validating this one again together. |
This is based on #1799 and replace it. Now, the normal UART driver is used instead of the specific code. It makes it possible to use on only arch, including ChibiOS. Binding is also possible, but for boards using ChibiOS and SD logger, it is recommanded to disable it for the binding process as the LSE clock required by the RTC is longer to start (bind pulses should be issued before 200ms after power up). The configuration is backward compatible and some defines in the boards' header could be even removed. Only Apogee, Chimera and Elle0 have been updated as it is the only board tested for now. There is no harm to keep the old defines.
|
In favor of #2250 I close this pull request. |
This is based on #1799 and replace it. Now, the normal UART driver is used instead of the specific code. It makes it possible to use on only arch, including ChibiOS. Binding is also possible, but for boards using ChibiOS and SD logger, it is recommended to disable it for the binding process as the LSE clock required by the RTC is longer to start (bind pulses should be issued before 200ms after power up). The configuration is backward compatible and some defines in the boards' header could be even removed. Only Apogee, Chimera and Elle0 have been updated as it is the only board tested for now. There is no harm to keep the old defines.
This is based on paparazzi#1799 and replace it. Now, the normal UART driver is used instead of the specific code. It makes it possible to use on only arch, including ChibiOS. Binding is also possible, but for boards using ChibiOS and SD logger, it is recommended to disable it for the binding process as the LSE clock required by the RTC is longer to start (bind pulses should be issued before 200ms after power up). The configuration is backward compatible and some defines in the boards' header could be even removed. Only Apogee, Chimera and Elle0 have been updated as it is the only board tested for now. There is no harm to keep the old defines.
This is a total rewrite of the Spektrum satellite parser, which also include support for DSMX!
Protocol information is available at http://www.spektrumrc.com/ProdInfo/Files/Remote%20Receiver%20Interfacing%20Rev%20A.pdf
Things that need to be done before merging: