Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rpm-control] throttle curves with rpm control #1878

Merged
merged 2 commits into from Jun 21, 2018
Merged

[rpm-control] throttle curves with rpm control #1878

merged 2 commits into from Jun 21, 2018

Conversation

dewagter
Copy link
Member

No description provided.

@flixr
Copy link
Member

flixr commented Oct 1, 2016

duplicate of #1832 ?

@podhrmic
Copy link
Member

podhrmic commented Oct 2, 2016

in general it would be nice to have more comments in the throttle_curve module, including some examples...

@dewagter dewagter self-assigned this Oct 6, 2016
@dewagter dewagter mentioned this pull request Oct 6, 2016
Closed
@dewagter
Copy link
Member Author

dewagter commented Oct 6, 2016 •
edited

  • All airframes files that use this need to be updated
  • Add airframe in conf_tests.xml
  • Add descriptions to the modules on what exactly they do and how they should be used
  • The added rpm_control.xml file seems superfluous...
  • Code style
  • Also why change the signature of throttle_curve_run? Now you don't pass autopilot_motors_on as parameter anymore but instead take the global var directly... but add ap_mode as parameter instead of using the global var in that case

@dewagter dewagter mentioned this pull request Nov 3, 2016
Closed
51 tasks
@dewagter dewagter force-pushed the obc_throttle_curves branch 4 times, most recently from 9b20e28 to a651e2f Compare November 3, 2016 14:20
@flixr
Copy link
Member

flixr commented Feb 12, 2017

any updates here?

@podhrmic
Copy link
Member

podhrmic commented May 7, 2017

@dewagter any updates here?

@OpenUAS
Copy link
Contributor

OpenUAS commented Jun 6, 2018

Work on this re-started by @fvantienen

@fvantienen fvantienen self-assigned this Jun 6, 2018
@fvantienen fvantienen force-pushed the obc_throttle_curves branch 3 times, most recently from 8ffa794 to 1e014f6 Compare June 21, 2018 13:01
@fvantienen
Copy link
Member

Failing only on the outback FBW because of interMCU. Fix will be in other PR and error is not because of this PR.

@fvantienen fvantienen merged commit 477558a into master Jun 21, 2018
@fvantienen fvantienen deleted the obc_throttle_curves branch June 21, 2018 15:21
biancabndris pushed a commit to biancabndris/paparazzi that referenced this pull request Aug 29, 2018
@fvantienen
Merge pull request paparazzi#1878 from paparazzi/obc_throttle_curves
0e74d34 
[rpm-control] throttle curves with rpm control
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dewagter dewagter

@fvantienen fvantienen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dewagter @flixr @podhrmic @OpenUAS @fvantienen