Erase dynamic sweep gvf #2534
Merged
Erase dynamic sweep gvf #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gautierhattenberger
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally I had some time to test the "dynamic sweep" in poly survey with GVF. It turns out that the code from that PR does not even compile when you set to true the corresponding define. The code does not make much sense anyway, so it is better to delete it.
Once I have a chance, I will also check whether the dynamic sweep works correctly with the original poly survey.
The bright side is in the second commit. I have found a bug in the GVF for tracking lines defined with two points. It did not work correctly for the corner case of "perfect horizontal lines" (90 or 270 degrees). Testing the poly survey triggered the bug. Now the fix is even more elegant, and I tested it thoruhgfully in simulation.