Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run FW AP and FBW on two different boards #297

Closed
wants to merge 9 commits into from

Conversation

dewagter
Copy link
Member

@dewagter dewagter commented Oct 8, 2012

Use 2 (Lisa) boards connected via serial cable to separately run AP and FBW.

http://www.youtube.com/watch?v=7CtFCHSjI-A

@flixr
Copy link
Member

flixr commented Oct 8, 2012

Just my 2cent:

  • To me it looks like the link_mcu*.h header files should be refactored into one common one...
  • I'm wondering why the UART implementation does not have/need a checksum??
  • The old link_mcu.c should probably be renamed into link_mcu_spi.c
  • the CAN implementation has SPI stuff in there, but commented out... should be removed
  • please no explicit LED numbering, we have way to many boards and configs...
    • e.g. introduce LINK_MCU_LED that will be used if defined, just like for the other led indicators

@dewagter
Copy link
Member Author

dewagter commented Oct 8, 2012

@flixr
Copy link
Member

flixr commented Oct 8, 2012

About the checksum: what I meant is why do SPI and CAN implementations have a checksum, UART not??

@dewagter
Copy link
Member Author

dewagter commented Oct 8, 2012

the link was supposed to go to lin 55 of link_uart.c which shows there IS a checksum in the UART.
(but the link gets processed:
https :// github.com/ paparazzi/ paparazzi/ pull/ 297/ files #L8R55 -> https://github.com/paparazzi/paparazzi/pull/297/files#L8R55

@flixr
Copy link
Member

flixr commented Oct 8, 2012

And also please remove the useless $ID and add proper doxygen headers for the files....

@dewagter
Copy link
Member Author

dewagter commented Oct 9, 2012

is it ok now or should link_mcu also move to ./firmware/fixedwing/

@dewagter dewagter closed this in 37f1cce Oct 9, 2012
@flixr
Copy link
Member

flixr commented Oct 9, 2012

If we want to do further cleaning like moving to firmwares/fixedwing, we do it in master..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants