Added KroozSD Big Rotorcraft Edition IMU driver #586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #include "subsystems/datalink/downlink.h" | ||
| #include "mcu_periph/sys_time.h" | ||
|
|
||
| #ifndef DOWNLINK_DEVICE |
|
What are the USE_RC_FP_BLOCK_SWITCHING and USE_LOW_BAT_AUTO_MODE_SWITCH defines? In imu_krooz_memsic.[ch]: please fix the doxygen @file path and the include guard to match the actual file names. |
|
Also please break overly long lines... |
| imu.accel_unscaled.y = imu_krooz.accel_filtered.y; | ||
| imu_krooz.accel_sum.y = 0; | ||
| imu_krooz.meas_nb_y = 0; | ||
| imu_krooz.acc_valid = TRUE; |
There was a problem hiding this comment.
Seems to me that acc_valid should only be set once all 3 axes are read....
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added KroozSD Big Rotorcraft Edition IMU driver with corresponding airframe setup example.