Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[types] add support for new telemetry types #589

Merged
merged 3 commits into from
Nov 19, 2013
Merged

[types] add support for new telemetry types #589

merged 3 commits into from
Nov 19, 2013

Conversation

gautierhattenberger
Copy link
Member

Coming from the old 'messages' branch:

  • support for char and 64 bits
  • support for fixed length arrays

@gautierhattenberger
[types] add support for new telemetry types
9613239 
Comming from the old 'messages' branch:
- support for char and 64 bytes
- support for fixed length arrays
@flixr
Copy link
Member

flixr commented Nov 14, 2013

There probably also needs to be a version of c_int64_of_indexed_bytes ifdef ARCH_ALIGN_INT64 similar to the double version.
And of course there might be a more efficient way to do this than how it's currently done..

@flixr
Copy link
Member

flixr commented Nov 14, 2013

Maybe we can actually use the caml_deserialize_x functions described in http://caml.inria.fr/pub/docs/manual-ocaml-4.00/manual033.html#toc150

@flixr
Copy link
Member

flixr commented Nov 15, 2013

Can't currently test this on ARM, but looks good to merge to me...

@gautierhattenberger
Copy link
Member Author

Some stuff were indeed missing...
It is now tested with sim, lpc and stm with pprz, xbee and ivy protocols

@flixr
Copy link
Member

flixr commented Nov 18, 2013

So you have now dropped support for the Pprz2 messages/protocol format (with timestamps)..?

@gautierhattenberger
Copy link
Member Author

gen_messages2 is only about the downlink using inline functions used for fms and that is probably already completely broken.
The timestamp stuff used with Pprz2 protocol is hardcoded with the logger firmware. I have just silent the compilation warning in link (hopefully without breaking it)

@flixr
Copy link
Member

flixr commented Nov 18, 2013

Ok, I guess it's good to merge then...

gautierhattenberger added a commit that referenced this pull request Nov 19, 2013
@gautierhattenberger
Merge pull request #589 from gautierhattenberger/pprz_type
74bb27a 
[types] add support for new telemetry types
@gautierhattenberger gautierhattenberger merged commit 74bb27a into paparazzi:master Nov 19, 2013
@gautierhattenberger gautierhattenberger deleted the pprz_type branch November 19, 2013 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gautierhattenberger @flixr