- [ardrone] added daren's mag freeze fix #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| system("gpio 177 -d lo 0 &"); // GPIO used to reset PIC | ||
| system("gpio 177 -d lo 1 &"); | ||
| // wait 20ms to retrieve data | ||
| for (int i=0;i<22;i++) |
There was a problem hiding this comment.
why making a for loop instead of a usleep of the correct time directly ?
gautierhattenberger
added a commit
that referenced
this pull request
Jul 7, 2014
[ardrone] added daren's mag freeze fix
| navdata_write(&cmd, 1); | ||
|
|
||
| // do the navboard reset via GPIOs | ||
| system("gpio 177 -d lo 0 &"); // GPIO used to reset PIC |
There was a problem hiding this comment.
why system instead of gpio_clear and gpio_set?
There was a problem hiding this comment.
i wasn't aware of those functions. will check.
|
fixed with 3bc524b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finally managed to put that piece here. please check. thx