Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ahrs] Integer rate integration fix #782

Merged
merged 1 commit into from
Aug 1, 2014

Conversation

EwoudSmeur
Copy link
Member

Fixed the integer rate integration. The conversion from int32_t to int64_t went wrong. Fast rates gave false quaternion updates.

@gautierhattenberger
Copy link
Member

It looks good to me, but I can't test it.
If I didn't made a mistake, you can have issues at around 900 deg/s. So we clearly need 64bits since our sensors saturate at 2000deg/s at full range.

@fvantienen
Copy link
Member

We already tested this on the ARdrone and seems to work as expected. Previously we had problems with fast turn rates, that's how we found the problem.
We debugged every step with a fast onboard debugger and noticed that you for sure need that 64bits it was supposed to be using but didn't.

@flixr
Copy link
Member

flixr commented Jul 31, 2014

Nice find! Seems this has been wrong and not noticed since Antoine added the implementation in 2011...
while at it, it would make sense to also convert this macro to a static inline function (no reason for this to be a macro, and functions are nicer to read/debug).

@agressiva
Copy link
Contributor

HUmmm, in my last flights with quadrocotper, when i turn the YAW very fast the attitude start to work very bad.

When i say fast ... is very fast... much more than 500deg/s (spin at max yaw )
I will try the same next week.

Date: Thu, 31 Jul 2014 14:39:22 -0700
From: notifications@github.com
To: paparazzi@noreply.github.com
Subject: Re: [paparazzi] [ahrs] Integer rate integration fix (#782)

It looks good to me, but I can't test it.

If I didn't made a mistake, you can have issues at around 900 deg/s. So we clearly need 64bits since our sensors saturate at 2000deg/s at full range.


Reply to this email directly or view it on GitHub.

@flixr flixr merged commit b050bda into paparazzi:master Aug 1, 2014
@flixr flixr added this to the v5.2 milestone Aug 1, 2014
@EwoudSmeur EwoudSmeur deleted the int_ahrs_fix branch August 10, 2014 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants