[messages] dist_home and dist_wp in meters instead of squared #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it looks good, but the GCS layout display the distance in a papget should be updated too |
|
Think that the papget should work now... |
|
yes, I think it's good |
also add dist_home for ROTORCRAFT_NAV_STATUS
|
Also added distance to waypoint to rotorcraft. Since this information is used on the ground to compute an approximate ETA (using distance to target waypoint and current speed) I also set the threshold to 0.5m distance and 0.5 m/s speed there as suggested by Gautier. |
flixr
added a commit
that referenced
this pull request
Aug 5, 2014
[messages] add dist_home and dist_wp for rotorcrafts and change it to meters instead of squared. Since dist_wp is used on the ground to compute an approximate ETA (using distance to target waypoint and current speed) the threshold to use that information is now to 0.5m distance and 0.5 m/s speed to not get bogus ETAs when hovering with the quad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also add dist_home for ROTORCRAFT_NAV_STATUS
Proposal to solve #761
Didn't test with old logs with dist2_wp in NAVIGATION, but should be properly dealt with...
@gautierhattenberger can probably comment on that...
We could also add dist_wp to the rotorcraft message if needed...