[messages] rename class to msg_class #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -230,7 +230,7 @@ let parse_msg_field = fun msg_descr field -> | |||
| (** Parse a complete message and build its representation *) | |||
| let parse_msg = fun msg -> | |||
| let msg_name = Xml.attrib msg "name" | |||
| and msg_class = Xml.attrib msg "class" | |||
| and msg_class = try Xml.attrib msg "msg_class" with Not_found -> Xml.attrib msg "class" | |||
| and send_always = (try (Xml.attrib msg "send_always") = "true" with _ -> false) in | |||
|
|
|||
| let fields, has_ac_id = | |||
There was a problem hiding this comment.
This "class" attribute refers to the on attribute in joysticks xml files (which have not been changed), not the node name "class".
Is it needed to change attributes as well ?
There was a problem hiding this comment.
Right, I'll remove that change...
makes it possible to use the python parser using xmlobject since class is a reserved word.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes it possible to use the python parser using xmlobject since class is a reserved word.
If I didn't miss anything it should still be possible to replay old logs and stuff like that...