Added xtend_rssi module and pwm_input mcu peripheral for lpc21xx arch #86
Conversation
…ged speech to use match expr with pattern instead of if then else, cleaner and now possible with no \n after os_name
…simple xml config file, changed gm.ml accordingly
…and still up to 327A max
…t driver for lpc21xx
…ule to compile properly, sources and headers not being included properly
* added pwm_input.c and pwm_input_arch.c to sources * make pwm_input_isr normal void functions for now * define PWM_INPUT_ITx to zero if not used
…resources for regular autopilot usage, can be added later if needed for something, cleaned up files a bit, fixed a couple mistakes (forgot a couple vars and changes on chan2)
|
It appears there are way more commits included even though the files changes are just a couple from recent master commits and the items I changes (with the help of Felix). Does it need a cleaner branch from dev? Would be fast for me to do this if it is cleaner/better. |
|
Should the pwm_input code have a module wrapper that can be a depend of the xtend_rssi module? This wrapper could call the init function ( pwm_input_init() ) and have the makefile section that includes the right files and defines USE_PWM_INPUT. Then the xtend_rssi module (and other modules, like the engine tachometer module I will add next) does not have to worry about including these files, just defining what is required for that specific module. Right now I think things would get messy if another module using some pwm input functionality were to be added, and one wished to use one, or the other, or both. I could change this and make a new pull request directly in dev, making it cleaner. |
|
If you already have another module that uses pwm_input in the pipeline, then yes... I think it would make sense include these files in an extra module (that then doesn't do anything except satisfy the dependency and include the pwm_input sources). If you work on a new feature it's good practice to make a new branch of the paparazzi master or dev branch for easier merging later. Cheers, Felix |
|
Making a new branch from dev and cherry-picking as suggested. |
This adds pwm_input functionality as an mcu_periph using code that used to be right in airborne/arch/lpc21/, currently only for lpc21xx arch. Also adds module using this pwm measurement to read and report rssi from Digi 9XTend radio modems.
Has been tested on the ground on a TWOG, seems to work, no problems so far that I have seen, but would be nice if someone else could try it...
Wiki update coming soon.
There are a couple stray commits from master I think also. Also there is a new diagram for the airspeed control loop on fw. (I suppose I should have tried to put this directly to master)