-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support showing location messages #548
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marhkb
force-pushed
the
feat/support-showing-location-messages
branch
2 times, most recently
from
September 22, 2023 23:17
7f391eb
to
da91bf6
Compare
This will be needed to support location messages.
Otherwise, for live locations, the `edited` label is displayed, which is a pleonasm, since it is inherent to the live location to edit itself. For normal locations we don't need to show it either, because they are not editable.
This property will soon be used for live location messages.
marhkb
force-pushed
the
feat/support-showing-location-messages
branch
from
September 22, 2023 23:26
da91bf6
to
a1f6404
Compare
This widget will soon be used in live location messages.
This component can be used as a marker on a `shumate::Map` and display any widget. The component has a special layouting which causes the component to be twice as high as its content. The content is always in the upper half. As a result, the bottom edge of the set widget of the component ends exactly at the geo position of the map.
It is intended to embed this component in the previously created 'MapMarker' component to be able to display a map marker with a user's avatar. This can be used for live locations.
The map will soon be embedded in location messages.
This message is able to display both static and live locations.
This commit enables location messages in the chat history.
marhkb
force-pushed
the
feat/support-showing-location-messages
branch
from
September 22, 2023 23:30
a1f6404
to
35f146a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.