fix: Cannot send pictures #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marhkb
force-pushed
the
fix/cannot-send-picture
branch
from
bf0be47
to
ba74ff0
Compare
The field `self_destruct_type` should be set to `None`. Otherwise, tdlib complains with "Invalid message content self-destruct time specified". In this turn, we clean up the code a bit, too.
The message weak ref will be `None` after the message has been removed from the chat history model and after the message's state went from `Pending` to `Sent`. Accessing the pending message is going to result in an error.
marhkb
force-pushed
the
fix/cannot-send-picture
branch
from
ba74ff0
to
2a4bfee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits.