Skip to content
This repository has been archived by the owner on Dec 14, 2020. It is now read-only.

Feat/revive rect #178

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Feat/revive rect #178

wants to merge 7 commits into from

Conversation

yoheiMune
Copy link
Collaborator

@aleyan
Copy link

aleyan commented Jul 30, 2018

Hi yoheiMune, I tried out this branch and the complementary branch in anno-ui, and outside of merge conflicts and some exporting stuff, it mostly seems to work. What would it take to get these two PRs merged? Region annotation is interesting to me and I can work on getting this done if you have other priorities right now.

@hshindo
Copy link
Member

hshindo commented Jul 31, 2018

@aleyan
It would be great if you could help us. (yoheiMune is busy.)
Currently, we're preparing a new release (v0.5.0).
After that, I was going to merge this.

@aleyan
Copy link

aleyan commented Jul 31, 2018

Great, I will see what I can do. For reference, is there any particular reason why rectangle annotation was removed in the first place?

@hshindo
Copy link
Member

hshindo commented Jul 31, 2018

Because it contained some bugs.
Note that when you mouse-click on PDF, if it is on a text, it should be a start of span annotation, otherwise, rectangle.

@Abhishek-maurya-19
Copy link

Hello @hshindo . Hope you are doing well. Can rectangle tool be integrated in your repo. If yes, then your suggestion will be of great help to me as i want to use rectangular tool in your repo.
Thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants