Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite with pure functional Either<Error, Result> pattern #29

Merged
merged 21 commits into from
Mar 30, 2021

Conversation

andrenarchy
Copy link
Member

Fixes #22.

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #29 (8d7acbd) into main (f0127ae) will increase coverage by 6.94%.
The diff coverage is 98.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   90.11%   97.05%   +6.94%     
==========================================
  Files          14       15       +1     
  Lines         172      204      +32     
  Branches       48       47       -1     
==========================================
+ Hits          155      198      +43     
+ Misses          6        2       -4     
+ Partials       11        4       -7     
Impacted Files Coverage Δ
src/array.ts 83.33% <90.00%> (+23.33%) ⬆️
src/object.ts 95.34% <97.22%> (+8.86%) ⬆️
src/boolean.ts 100.00% <100.00%> (ø)
src/date.ts 100.00% <100.00%> (ø)
src/enumerate.ts 100.00% <100.00%> (ø)
src/errors.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/number.ts 100.00% <100.00%> (ø)
src/parse-boolean.ts 100.00% <100.00%> (+11.11%) ⬆️
src/parse-date.ts 100.00% <100.00%> (+10.00%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0127ae...8d7acbd. Read the comment docs.

@andrenarchy andrenarchy marked this pull request as ready for review March 30, 2021 08:54
@andrenarchy andrenarchy merged commit 5031eaa into main Mar 30, 2021
@andrenarchy andrenarchy deleted the feature/either-pattern branch March 30, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite fefe with functional Either<Error, Result> pattern
1 participant