-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: v1.7.1 frontend visual fixes #933
Conversation
You sir, are amazing! Big Thx! |
Good point. Should be looking similar. Nur from M point of view, I'd say, on mobile, there only should be buttons instead of text, since I would assume this can be aligned much easier. But I'm definitely not a front end guy. Good Icons will be hard to find though. |
I generally agree with this. Ideally the 3 dots icon might open a small menu above with more options, one of them being "Ähnliche Dokumente". I'm not a frontend guy either, but I imagine that's a lot more work than this quick fix intened. |
I can take a look later, yea some things are just compromises, like wrapping buttons. If it works well in many (most) languages its hard to justify making it "worse" for others just to achieve parity, but certainly that screenshot above shouldnt be left as-is. Leave me to it. |
The wrapping is totally fine IMO and a great compromise |
35bf838
to
c8da513
Compare
Definitely a good solution to the card view to just use icons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks shamoon
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Proposed change
This PR fixes two visual issues reported in v1.7.1, specifically:
Screenshots below to illustrate fixes.
Fixes #931 and #932
Type of change
Checklist:
pre-commit
hooks, see documentation.I have made corresponding changes to the documentation as needed.