Show persistent viewport window position indicator in topbar (completes #471) #476

jtaala · 2023-02-21T14:13:37Z

Fixes #471

This PR adds a window position indicator bar as described in #471.

The bar style can be overriden with the css class paperwm-window-position-bar.

I've also added a schema property to enable/disable showing the position bar.
You can disable it from the command line with:
dconf write /org/gnome/shell/extensions/paperwm/show-window-position-bar false
and enable it with
dconf write /org/gnome/shell/extensions/paperwm/show-window-position-bar true

See the window position bar (topbar blue coloured segment indicating window tiled position) in the video below:

paperwm-window-position-bar.mp4

Feedback welcome!

The indicator might not be wanted by some users - so, it might be worth adding a toggle in the paperwm preference ui.

NOTE: this PR has been implemented in the PaperWM-redux fork, which you can install if you want this, or any of my other open PRs.

forceTransparency method in topbar which ensures transparency is maintained so window indicator can be seen.

indicator now.

Lythenas · 2023-02-21T18:30:21Z

I think this looks very good.

But I have a comment about the naming: "Window indicator" is really generic and does not really tell you anything. So at the very least we should document it properly in the code (and probably readme) what exactly it is. Also I guess it looks effectively like a scroll bar, so maybe that is a better name for it?

Also maybe we need some discussion about the default color, but it is easily configurable so maybe not that important. The default color of the window selection comes from the .tile-preview class, which is defined in the gnome theme. Also if I remember correctly on one gnome version I was able to select a color in the gnome settings and it also changed the paperwm window selection color, but on gnome 43.2 I can't find that setting anymore. I guess what I'm getting at is: What should be the default color? The same as the window selection or another one?

jtaala · 2023-02-21T21:56:04Z

Thanks @Lythenas ,

But I have a comment about the naming: "Window indicator" is really generic and does not really tell you anything. So at the very least we should document it properly in the code (and probably readme) what exactly it is. Also I guess it looks effectively like a scroll bar, so maybe that is a better name for it?

I guess it does look like a scroll bar, my only issue with referring to it as a scroll bar is that that name has some meaning behind it - e.g. users will likely try to click on it and drag it left/right (like s a scroll bar) . What about something like viewport position indicator? or maybe a mix: viewport position bar? Actually that last one sounds pretty good(?). Open to other names/ideas.

Also maybe we need some discussion about the default color, but it is easily configurable so maybe not that important. The default color of the window selection comes from the .tile-preview class, which is defined in the gnome theme. Also if I remember correctly on one gnome version I was able to select a color in the gnome settings and it also changed the paperwm window selection color, but on gnome 43.2 I can't find that setting anymore. I guess what I'm getting at is: What should be the default color? The same as the window selection or another one?

I think using tile-preview style/colors as the default color is good here and thinking about it should have been the default I went with. I just chose green because I wanted it to stand out a bit for showcasing what this thing is. I'll change the default style and throw up another video tonight to see what it looks like.

Cheers!

slurped windows are now taken into consideration.

(paperwm-window-position-bar).

jtaala · 2023-02-22T22:16:46Z

Thoughts? should the position bar be shown when there is only one window? or only when there is at least two windows?

Showing with one window seems a bit much? (not too useful?).

to have this call).

…dget (so position bar colour not obscured by topbar). Original implementation had the topbar transparency set and the position bar behind it. This was okay, but the position bar colours were obscured/darkened by the topbar. This new implementation has the position bar sitting on top a backdrop widget (which has some transparency). Now the position bar colour shows unobscured.

deprecated/no-longer-used css class from stylesheet). Added window-position-bar-backdrop css class so it can be styled by users if wanted.

disable/enable and style etc.).

…ewport-position

jtaala · 2023-03-07T11:59:19Z

Hey all! I've been testing this in anger the last two weeks and has been working great.

I'm planning on merging this in one week, please post any comments or thoughts re this PR if you have any.

Lythenas

Overall I think the code looks good.

I will try this out for the next couple of days, before approving.

README.md

tiling.js

topbar.js

Co-authored-by: Matthias Seiffert <matthias-seiffert@hotmail.de>

Lythenas · 2023-03-08T08:02:20Z

On my work computer right now (running Gnome 42.5, if that matters) and I'm currently using dash-to-panel (don't remember exactly why that extension, probably just so I have the topbar on all monitors). In general it seems to work. But two small issues:

The "Show Applications" button is misaligned. But only on the primary monitor. And only after switching focus to secondary monitor and back. (could be cause by dash-to-panel)
The workspace name is now shown twice on the primary monitor and the name is now also shown on the secondary monitor (which I like) but is badly aligned.
Also when switching workspaces (Super + PageUp/Down) the workspace name is also misaligned (similar to the second monitor) and there is a gray bar at the top (maybe the backdrop).

Regarding dash-to-panel:

I also had to manually set it transparent in its settings. But that is probably fine.

As far as I know gnome-shell has no generic topbar API. I'm not sure we should specifically support dash-to-panel. But I think we should either:

provide a way to show the topbar on all monitors (maybe that is now also possible with vanilla gnome-shell)
support at least one extension that does that.

I've also been working on a PR that would show the "Workspace X" menu on all topbars and I didn't find a way to generically get all topbar. I.e. I had to access global.dashToPanel which is set by that specific extension.

I don't have any particular reason to use dash-to-panel over any other extension. So I'm happy to switch to another. But we can also discuss this later.

…(including `Make topbar follow monitor focus` option).

jtaala · 2023-03-08T12:39:17Z

~~NOTE: I'm still working through some bugs with the Make topbar follow monitor focus option... grrrr~~ ✔️

Added fix/final space layout call to initWorkspaces to allow for topbar/window position bar init completion.

return topbar to primary and then set monitor.

Lythenas · 2023-03-08T18:17:43Z

If I have a fullscreen application (e.g. a fullscreen youtube video, or just firefox with F11) the window indicator is not shown (or I guess it is below the window), which is good. But if I then focus a different monitor. The window indicator is shown above the fullscreen window. If I focus the fullscreen window again, it corrects itself (after a short delay). This also happens if show-window-position-bar is disabled (but just with the backdrop).

Also with your multi monitor changes the backdrop is also shown if I disable show-window-position-bar. I think we should (as far as possible) keep the old behavior if the feature is disabled.

And it seems like disabling the feature does not return the original opacity of the topbar.

With dash-to-panel there are still some issues (actually even more after the multi monitor changes^^). But I will try to think of something independent of this PR.

Lythenas · 2023-03-08T18:20:31Z

Also I think we should decide if this will now be the new default behavior or if it will just be an addon feature.

In any case I think we should also add a setting for this in the UI. But that can be a separate PR when we know there are no more bugs.

Lythenas · 2023-03-08T20:00:42Z

Not sure if this was broken by this PR, but the workspace border/header when navigating is different that it used to be:

Now:

Previous (from README):

jtaala · 2023-03-08T21:16:11Z

Not sure if this was broken by this PR, but the workspace border/header when navigating is different that it used to be:

Now:

Previous (from README):

Ah ha yes! that was by design (shows the backdrop and indicator just like normal view). My thinking:

I wanted to have the workspace previews (when switching) look like the actual view;
it's easier (for me at least) to see the workspace name, and much easier to see the "focus mode" icon in #482, regardless of what workspace colour or background you use (e.g. light colours or light background - I prefer seeing my background). I note issue Make the default workspace color palette better #127 re workspace colours and some visual issues it can bring - this choice was to avoid/minimise this. E.g. make the workspace name (and other stuff like PR #482) easy to see regardless of workspace colours);
you can actually see and use the workspace indicator from switching view (give it a try with switching windows with shortcut keys from the workspace switching view. It then looks the same as in normal views (albeit a zoomed out view) ;
looks betterer! (although, this could just be an opinion of mine);

jtaala · 2023-03-08T21:32:56Z

If I have a fullscreen application (e.g. a fullscreen youtube video, or just firefox with F11) the window indicator is not shown (or I guess it is below the window), which is good. But if I then focus a different monitor. The window indicator is shown above the fullscreen window. If I focus the fullscreen window again, it corrects itself (after a short delay). This also happens if show-window-position-bar is disabled (but just with the backdrop).

Good pickup! Will fix that.

Also with your multi monitor changes the backdrop is also shown if I disable show-window-position-bar. I think we should (as far as possible) keep the old behavior if the feature is disabled.

Yeah, sounds good - I originally thought to just leave the backdrop there but what you mentioned is probably a better choice (return things to how they were).

And it seems like disabling the feature does not return the original opacity of the topbar.

Original opacity - you mean like being opaque? Interestingly, PaperWM TopBar.js sets the opacity to be slightly transparent (assuming it will stay like that) but gnome can clobber it (e.g. without this PR, right after a login, try going into overview and then clicking a window - gnome will set the topbar opaque). This PR fixes that long-standing issue (although it might not be what people are used to now?).

windowPositionBar actors and restores original topbar.

position bar is enabled.

window.

jtaala · 2023-03-09T14:58:11Z

If I have a fullscreen application (e.g. a fullscreen youtube video, or just firefox with F11) the window indicator is not shown (or I guess it is below the window), which is good. But if I then focus a different monitor. The window indicator is shown above the fullscreen window. If I focus the fullscreen window again, it corrects itself (after a short delay). This also happens if show-window-position-bar is disabled (but just with the backdrop).

Fixed this.

jtaala · 2023-03-09T15:18:06Z

Also with your multi monitor changes the backdrop is also shown if I disable show-window-position-bar. I think we should (as far as possible) keep the old behavior if the feature is disabled.

Have implemented this. Now, disabling the window position bar will completely disable it and revert back to previous behaviour.

Although, the issue with the topbar opacity (starting out as transparent but then gnome cloberring it to opaque) has been fixed (as in, PaperWM will enforce that transparency as it was originally designed to). I'm remiss to revert back to the broken behaviour - if we want the topbar to be opaque like vanilla gnome then we should just remove that transparency code. I do note that #344 suggests NOT having PaperWM change transparency.

Now, we use transparency to good effect with the window position bar (and I like it! lol) but, I'm open to suggestions re this, for example we could:

keep transparency and fix the code (current behaviour with this PR);
do away with transparent topbar and let users add that if wanted (via css styling in PaperWM or other extensions etc.);
hybrid approach: if window position bar is disabled then we could have an opaque topbar (vanilla gnome) and keep transparency for when window position bar is enabled;

Option 2 would simplify things I guess. If not, will go ahead with the first option (since that's what we've got atm).

jtaala · 2023-03-09T15:20:14Z

@Lythenas, fixed those issues you raised, could you give the latest a test when you can? Cheers!

now on top of the window position bar.

Lythenas

This looks good to me. I haven't noticed any more issues.

Thanks for the awesome feature.

enabling/disabling.

enough feature to justify adding to the preferences ui.

jtaala · 2023-03-11T00:45:42Z

This looks good to me. I haven't noticed any more issues.

Thanks for the awesome feature.

Thanks @Lythenas! I've just cleaned up some stuff and also I did end up adding the enable/disable toggle to the settings ui. I believe this feature is a big enough, prominent enough, and changes enough of the previous behaviour to justify adding it to the settings ui.

I also updated the README.md and added the video from this PR to it.

I'll merge this shortly.

jtaala added 2 commits February 22, 2023 00:31

Added window position indicator which sits behind the topbar. Added

010e768

forceTransparency method in topbar which ensures transparency is maintained so window indicator can be seen.

Moved window indicator style to stylesheet.css. Setting a green

fb66356

indicator now.

jtaala marked this pull request as draft February 21, 2023 14:13

jtaala requested review from smichel17 and Gelbana February 21, 2023 14:16

jtaala added 5 commits February 22, 2023 18:46

Styles now use tile-preview by default.

c854978

Added topbar transparency setting over exiting from overview.

6ffe0d7

Now referring to indicator as "window position bar".

9d238fd

Now using space columns (instead of number of windows) - means the

57ac9e6

slurped windows are now taken into consideration.

FIX: updated stylesheet.css to use new name

9b40f68

(paperwm-window-position-bar).

jtaala mentioned this pull request Feb 22, 2023

Fix showing margin on display edges when switching apps #364

Closed

jtaala added 3 commits February 24, 2023 21:47

Added boolean option to show window position bar to gschema.

3b41f09

Implemented listener of signal change which will hide/show position bar.

1feefe2

Added the updateWindowPositionBar call to updateSelection (better place

ca52f40

to have this call).

jtaala marked this pull request as ready for review February 24, 2023 13:04

jtaala self-assigned this Feb 25, 2023

jtaala added 4 commits February 27, 2023 00:52

Moved hardcoded styles to stylesheet.css (and removed

7fc68f4

deprecated/no-longer-used css class from stylesheet). Added window-position-bar-backdrop css class so it can be styled by users if wanted.

Added section in README.md about the window position bar (how to

a67f096

disable/enable and style etc.).

Merge remote-tracking branch 'upstream/develop' into indication-of-vi…

c3d8cd8

…ewport-position

jtaala requested review from Lythenas and removed request for Gelbana March 6, 2023 21:42

Lythenas requested changes Mar 7, 2023

View reviewed changes

README.md Outdated Show resolved Hide resolved

tiling.js Show resolved Hide resolved

tiling.js Show resolved Hide resolved

topbar.js Outdated Show resolved Hide resolved

jtaala and others added 2 commits March 8, 2023 08:13

Update README.md

7dbda8c

Co-authored-by: Matthias Seiffert <matthias-seiffert@hotmail.de>

Implementing suggestions by @Lythenas.

4d0eab4

Added mutli-monitor support for keeping position bar on all monitors …

94df7cd

…(including `Make topbar follow monitor focus` option).

jtaala added 2 commits March 9, 2023 00:51

Moved workarea topbar compenstaion to layout (more appropriate here).

a8099d3

Added fix/final space layout call to initWorkspaces to allow for topbar/window position bar init completion.

FIXES: change::topbar-follow-focus had errors - when disabling must

3ee0b80

return topbar to primary and then set monitor.

Setting show-window-position-bar to false now removes the

7151eda

windowPositionBar actors and restores original topbar.

jtaala force-pushed the indication-of-viewport-position branch from 4655d57 to 7151eda Compare March 9, 2023 13:10

jtaala added 2 commits March 10, 2023 01:28

FIX: only implement window position bar for multi-monitor if window

4f752cd

position bar is enabled.

FIX: don't show window position topbar if space has a fullscreened

1ebe19b

window.

jtaala added 2 commits March 10, 2023 02:45

Small visual improvement: in workspace switching view, workspace name is

bbf6275

now on top of the window position bar.

FIX: now shows the workspace name on secondary (etc.) monitors.

31c134d

Lythenas approved these changes Mar 10, 2023

View reviewed changes

jtaala added 2 commits March 11, 2023 10:26

Improvement to cleanup when changing window position indicator bar

a91e5b5

enabling/disabling.

Added window position bar toggling to the settings ui. It's a prominent

3f16001

enough feature to justify adding to the preferences ui.

jtaala force-pushed the indication-of-viewport-position branch from 61700ea to b25473f Compare March 11, 2023 00:39

Updated README.md.

5df2228

jtaala force-pushed the indication-of-viewport-position branch from b25473f to 5df2228 Compare March 11, 2023 00:41

jtaala merged commit 97acf9d into paperwm:develop Mar 11, 2023

jtaala mentioned this pull request Mar 16, 2023

Disable features that conflict with Dash to Panel #420

Closed

Lythenas mentioned this pull request Mar 21, 2023

Remove transparency from the top toolbar #496

Closed

This was referenced Apr 8, 2023

Add option to entirely disable the workspace name / activities button #387

Closed

Alternative layout suggestion for workspace indicator #433

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show persistent viewport window position indicator in topbar (completes #471) #476

Show persistent viewport window position indicator in topbar (completes #471) #476

jtaala commented Feb 21, 2023 •

edited

Lythenas commented Feb 21, 2023

jtaala commented Feb 21, 2023 •

edited

jtaala commented Feb 22, 2023 •

edited

jtaala commented Mar 7, 2023 •

edited

Lythenas left a comment

Lythenas commented Mar 8, 2023 •

edited

jtaala commented Mar 8, 2023 •

edited

Lythenas commented Mar 8, 2023 •

edited

Lythenas commented Mar 8, 2023

Lythenas commented Mar 8, 2023 •

edited

jtaala commented Mar 8, 2023

jtaala commented Mar 8, 2023 •

edited

jtaala commented Mar 9, 2023

jtaala commented Mar 9, 2023

jtaala commented Mar 9, 2023 •

edited

Lythenas left a comment

jtaala commented Mar 11, 2023 •

edited

Show persistent viewport window position indicator in topbar (completes #471) #476

Show persistent viewport window position indicator in topbar (completes #471) #476

Conversation

jtaala commented Feb 21, 2023 • edited

See the window position bar (topbar blue coloured segment indicating window tiled position) in the video below:

Feedback welcome!

Lythenas commented Feb 21, 2023

jtaala commented Feb 21, 2023 • edited

jtaala commented Feb 22, 2023 • edited

jtaala commented Mar 7, 2023 • edited

Lythenas left a comment

Choose a reason for hiding this comment

Lythenas commented Mar 8, 2023 • edited

jtaala commented Mar 8, 2023 • edited

Lythenas commented Mar 8, 2023 • edited

Lythenas commented Mar 8, 2023

Lythenas commented Mar 8, 2023 • edited

jtaala commented Mar 8, 2023

jtaala commented Mar 8, 2023 • edited

jtaala commented Mar 9, 2023

jtaala commented Mar 9, 2023

jtaala commented Mar 9, 2023 • edited

Lythenas left a comment

Choose a reason for hiding this comment

jtaala commented Mar 11, 2023 • edited

jtaala commented Feb 21, 2023 •

edited

jtaala commented Feb 21, 2023 •

edited

jtaala commented Feb 22, 2023 •

edited

jtaala commented Mar 7, 2023 •

edited

Lythenas commented Mar 8, 2023 •

edited

jtaala commented Mar 8, 2023 •

edited

Lythenas commented Mar 8, 2023 •

edited

Lythenas commented Mar 8, 2023 •

edited

jtaala commented Mar 8, 2023 •

edited

jtaala commented Mar 9, 2023 •

edited

jtaala commented Mar 11, 2023 •

edited