Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some documentation and renamed template types #66

Merged
merged 2 commits into from
Jul 22, 2020
Merged

Conversation

Javuto2
Copy link
Contributor

@Javuto2 Javuto2 commented Jul 22, 2020

As discussed in issue #36, this pull request adds some comments to make it easier to understand the library.
This also renames some of the types used in templates to better explain what they are.

Some of the renamed types include:

  • B -> TRequest
  • R -> TResponse
  • P -> TParams
  • A -> TAuth

For now this pull request includes only the most common classes and functions so that the maintainers can review it and see if they are ok with these changes.

@Wicpar Wicpar merged commit 1b1752a into papsign:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants