Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: depend on eip3074-tools image digest #50

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

fgimenez
Copy link
Member

ghcr.io/fgimenez/eip3074-tools image is rebuilt on each push to main in https://github.com/fgimenez/eip-3074-tools, and the solc binary included has a different timestamped version on each build, like 0.8.24-develop.2024.4.11+commit.c3af02c2.mod.

This version is included as part of the artifacts compiled from that solc, making the check in this repo fail if the ghcr.io/fgimenez/eip3074-tools image was updated.

These changes fix the image dependency to a concrete digest, so that we are not affected by changes in the image.

@fgimenez fgimenez requested a review from mattsse April 12, 2024 15:08
@fgimenez fgimenez requested a review from Rjected as a code owner April 12, 2024 15:08
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgimenez fgimenez merged commit bcef64a into main Apr 12, 2024
13 checks passed
@fgimenez fgimenez deleted the fgimenez/fix-bytecode-check branch April 12, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants