split validate_block_pre_execution into hardfork specific functions

[mattsse]

Describe the feature

we currently apply all checks in a single function

reth/crates/consensus/common/src/validation.rs

Lines 40 to 49 in 7df7bc2

	/// Validate a block without regard for state:
	///
	/// - Compares the ommer hash in the block header to the block body
	/// - Compares the transactions root in the block header to the block body
	/// - Pre-execution transaction validation
	/// - (Optionally) Compares the receipts root in the block header to the block body
	pub fn validate_block_pre_execution(
	block: &SealedBlock,
	chain_spec: &ChainSpec,
	) -> Result<(), ConsensusError> {

ideally all those hardfork checks are available as function and validate_block_pre_execution would then call all of them

TODO

• extract hardfork checks into separate functions:

reth/crates/consensus/common/src/validation.rs

Lines 63 to 102 in 7df7bc2

	// EIP-4895: Beacon chain push withdrawals as operations
	if chain_spec.is_shanghai_active_at_timestamp(block.timestamp) {
	let withdrawals =
	block.withdrawals.as_ref().ok_or(ConsensusError::BodyWithdrawalsMissing)?;
	let withdrawals_root = reth_primitives::proofs::calculate_withdrawals_root(withdrawals);
	let header_withdrawals_root =
	block.withdrawals_root.as_ref().ok_or(ConsensusError::WithdrawalsRootMissing)?;
	if withdrawals_root != *header_withdrawals_root {
	return Err(ConsensusError::BodyWithdrawalsRootDiff(
	GotExpected { got: withdrawals_root, expected: *header_withdrawals_root }.into(),
	))
	}
	}
	// EIP-4844: Shard Blob Transactions
	if chain_spec.is_cancun_active_at_timestamp(block.timestamp) {
	// Check that the blob gas used in the header matches the sum of the blob gas used by each
	// blob tx
	let header_blob_gas_used = block.blob_gas_used.ok_or(ConsensusError::BlobGasUsedMissing)?;
	let total_blob_gas = block.blob_gas_used();
	if total_blob_gas != header_blob_gas_used {
	return Err(ConsensusError::BlobGasUsedDiff(GotExpected {
	got: header_blob_gas_used,
	expected: total_blob_gas,
	}))
	}
	}
	// EIP-7685: General purpose execution layer requests
	if chain_spec.is_prague_active_at_timestamp(block.timestamp) {
	let requests = block.requests.as_ref().ok_or(ConsensusError::BodyRequestsMissing)?;
	let requests_root = reth_primitives::proofs::calculate_requests_root(&requests.0);
	let header_requests_root =
	block.requests_root.as_ref().ok_or(ConsensusError::RequestsRootMissing)?;
	if requests_root != *header_requests_root {
	return Err(ConsensusError::BodyRequestsRootDiff(
	GotExpected { got: requests_root, expected: *header_requests_root }.into(),
	))
	}
	}

Additional context

No response

[willco-1]

feel free to assign this to me!