Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return incoming Hello on p2p handshake #157

Closed
Rjected opened this issue Nov 3, 2022 · 0 comments · Fixed by #161
Closed

Return incoming Hello on p2p handshake #157

Rjected opened this issue Nov 3, 2022 · 0 comments · Fixed by #161
Labels
A-devp2p Related to the Ethereum P2P protocol C-enhancement New feature or request

Comments

@Rjected
Copy link
Member

Rjected commented Nov 3, 2022

Currently we initialize a p2p connection is by creating an UnauthedP2PStream, which returns the authenticated P2PStream<S> when UnauthedP2PStream::handshake completes successfully.

Instead, UnauthedP2PStream should return the successful Hello message in addition to the P2PStream<S>.
@Rjected Rjected added A-devp2p Related to the Ethereum P2P protocol C-enhancement New feature or request labels Nov 3, 2022
This was referenced Nov 3, 2022
Merged
Closed
Merged
yutianwu pushed a commit to yutianwu/reth that referenced this issue Oct 24, 2024
@unclezoro
Merge pull request paradigmxyz#157 from bnb-chain/new-engine
e1527d8 
chore: merge upstream v1.0.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-devp2p Related to the Ethereum P2P protocol C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eth-wire): return Hello on handshake paradigmxyz/reth
1 participant
@Rjected