Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: download blocks in merkle debug script #4137

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Aug 10, 2023

This improves the merkle debug script to download blocks, then run the rest of the script. Blocks are inserted before the execution stage runs.

TODO:

  • testing

@Rjected Rjected added A-cli Related to the reth CLI A-trie Related to Merkle Patricia Trie implementation labels Aug 10, 2023
@Rjected Rjected requested a review from rkrasiuk August 10, 2023 03:55
@Rjected Rjected requested a review from onbjerg as a code owner August 10, 2023 03:55
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #4137 (0bd6804) into main (4de1ff0) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/debug_cmd/merkle.rs 0.82% <0.00%> (-0.33%) ⬇️
bin/reth/src/debug_cmd/mod.rs 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.84% <0.00%> (-0.04%) ⬇️
unit-tests 64.00% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.62% <0.00%> (-0.33%) ⬇️
blockchain tree 82.83% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.75% <ø> (ø)
trie 94.71% <ø> (ø)
txpool 47.66% <ø> (ø)
networking 77.67% <ø> (-0.06%) ⬇️
rpc 58.70% <ø> (-0.01%) ⬇️
consensus 63.76% <ø> (ø)
revm 32.26% <ø> (ø)
payload builder 6.57% <ø> (ø)
primitives 87.90% <ø> (-0.01%) ⬇️

Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing, thanks! there's probably room for deduplication, but we can address it later

@rkrasiuk rkrasiuk added this pull request to the merge queue Aug 14, 2023
Merged via the queue into main with commit dfdfea8 Aug 14, 2023
24 checks passed
@rkrasiuk rkrasiuk deleted the dan/download-in-merkle-debug-script branch August 14, 2023 11:11
alessandromazza98 pushed a commit to alessandromazza98/reth that referenced this pull request Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI A-trie Related to Merkle Patricia Trie implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants