-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): use mdbx_txn_reset
to time out transactions
#6924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-enhancement
New feature or request
A-db
Related to the database
labels
Mar 1, 2024
shekhirin
force-pushed
the
alexey/mdbx-txn-reset-2
branch
from
March 1, 2024 22:30
6299305
to
61bbe2f
Compare
emhane
approved these changes
Mar 3, 2024
Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
DaniPopes
approved these changes
Mar 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE: running on Mainnet and Holesky over the weekends
Ref #6850, attempt number two.
Fixes several things:
MDBX_TXN_FINISHED
flag with one atomic boolreth/crates/storage/libmdbx-rs/src/transaction.rs
Lines 541 to 545 in 61bbe2f
TransactionPtr
mutex first, log on failure, then lock again in a blocking wayreth/crates/storage/libmdbx-rs/src/transaction.rs
Lines 551 to 563 in 61bbe2f
txn_execute
usages back to their original places 75fa00cmdbx_result
errors onDrop
,unwrap()
instead.