refactor(txpool): consider below proto fee cap an error #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
added
C-enhancement
rakita
reviewed
Oct 14, 2022
| if fee > self.minimal_protocol_basefee { | ||
| state.insert(TxState::ENOUGH_FEE_CAP_PROTOCOL); | ||
| if fee_cap >= self.pending_basefee { | ||
| state.insert(TxState::ENOUGH_FEE_CAP_BLOCK); | ||
| } |
There was a problem hiding this comment.
nit for later. We can reasonably add check for tx.gas_limit < block.target_gas_limit or <block.target_gas_limit/2 (as min gas limit ). This is not consensus restricted as target_gas_limit is something set by validators as configuration but it should be fine to have it.
There was a problem hiding this comment.
right, I haven't implemented this check yet, but there's already a block_gas_limit field that will hold this value.
There was a problem hiding this comment.
There is block.gas_limit but it changes over time (by max +-12.5% I think) as variable block size is introduced with eip1559, config.target_gas_limit is what is set and expected to be the same with the majority of nodes but it is config value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of tracking the
feeCap_tx > proto_feecaprequirement as part of the state, treat it as an error.This is sound, since a tx that can't satisfy this condition will never become valid, since the lower bound of the protocol feecap is constant (7 WEI).