Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace tokio-retry with backon and remove RetryStrategy #8613

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Replace tokio-retry with backon and remove RetryStrategy #8613

merged 2 commits into from
Jun 5, 2024

Conversation

sergerad
Copy link
Contributor

@sergerad sergerad commented Jun 5, 2024 •
edited
Loading

  • Remove RetryStrategy and tokio-retry
  • Remove retry_millis arg
  • Rename retry_attempts arg to dns_retries
  • Use backon

@sergerad sergerad force-pushed the serge/backon branch 2 times, most recently from 7981a57 to 3e018aa Compare June 5, 2024 10:31
@sergerad sergerad mentioned this pull request Jun 5, 2024
Merged
@sergerad sergerad marked this pull request as ready for review June 5, 2024 10:32
mattsse
mattsse requested changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty,
pedantic dependency nit

crates/node/builder/Cargo.toml Outdated
@@ -58,6 +57,7 @@ eyre.workspace = true
fdlimit.workspace = true
confy.workspace = true
rayon.workspace = true
backon = "0.4"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be converted to workspace dep

Rjected
Rjected approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Rjected Rjected requested a review from mattsse June 5, 2024 22:03
@mattsse mattsse merged commit 7bc27a3 into paradigmxyz:dan/dns-resolution-on-enodes Jun 5, 2024
26 checks passed
Rjected pushed a commit that referenced this pull request Jun 5, 2024
@sergerad @Rjected
Replace tokio-retry with backon and remove RetryStrategy (#8613)
83323eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Rjected approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg

@emhane emhane Awaiting requested review from emhane

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergerad @Rjected @mattsse