fix: also set configured bootnodes for discv5 #9885
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9883
we didn't configure the provided --bootnodes for discv5.
geth also uses the --bootnodes values to initialize discv5 bootnodes:
https://github.com/ethereum/go-ethereum/blob/380688c636a654becc8f114438c2a5d93d2db032/cmd/utils/flags.go#L1087-L1087
so this fix is reasonable imo.
I also added extend the discv5 bootnodes during network launch, this is redundant if the discv5 is already configured with the bootnodes, but doesn't hurt
reth/crates/net/network/src/manager.rs
Lines 217 to 220 in 76513e4