Add MakeCredential and ActivateCredential to Context #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
ionut-arm
approved these changes
Dec 8, 2020
| @@ -653,6 +653,77 @@ impl Context { | |||
| } | |||
| } | |||
|
|
|||
| pub fn activate_credential( | |||
There was a problem hiding this comment.
Hah! I had actually typed those, but then realized just now that I never committed that!
There was a problem hiding this comment.
Actually, are we missing some clippy lint here, I would've thought the CI should fail if something wasn't documented. Or was it because we have way too many types and most are not documented?
There was a problem hiding this comment.
There was a problem hiding this comment.
We have so much stuff undocumented so enable that would mean a serious amount of errors.
These are basically buffers, but they used a different field name. So in order to accomodate that, I abstracted the buffer_type to named_field_buffer_type. Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
This implements the MakeCredential and ActivateCredential TPM2 commands. Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
puiterwijk
force-pushed
the
make_activate_credential
branch
from
022f3be
to
f62c08a
Compare
Superhepper
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.