Implement abstraction::ak #166
Conversation
puiterwijk
force-pushed
the
aik
branch
2 times, most recently
from
357706d
to
741d4c7
Compare
There was a problem hiding this comment.
Looks good - don't know if you want to add any docs to those public methods, but it's not mandatory.
Also, before we bump the major version number, we should look at adding some doctests and examples, even if it's just copying some of the context tests we use now.
puiterwijk
force-pushed
the
aik
branch
2 times, most recently
from
6bb5ff8
to
ba92ba4
Compare
| SignatureScheme::EcDaa => TPM2_ALG_ECDAA, | ||
| SignatureScheme::EcSchnorr => TPM2_ALG_ECSCHNORR, | ||
| SignatureScheme::Sm2 => TPM2_ALG_SM2, | ||
| SignatureScheme::Rsa(ss) => ss.into(), |
There was a problem hiding this comment.
Yes! This is much better. The previous(mine) was just taking any alg in the specification and putting up as enum without any closer thought behind it. This is a huge improvement,
puiterwijk
force-pushed
the
aik
branch
2 times, most recently
from
b16baa3
to
78aa77d
Compare
Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
This adds a function to create an AK object and return it from the template from the tss2-tools, and also a function to load a created AK object. Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
This makes that we only have the different signature scheme encodings once. Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
|
@Superhepper Do you want to re-review it? |
|
If not, we can go ahead and merge - do you need a release after this, @puiterwijk ? |
|
@ionut-arm That would be great, yeah. Since this is the last thing we need for keylime-rust. |
|
@Superhepper gave me a "Merge it" on Slack, so doing so! |
Replace calendar iframe with URL
This adds a function to create an AK object and return it
from the template from the tss2-tools, and also a function
to load a created AK object.
Signed-off-by: Patrick Uiterwijk patrick@puiterwijk.org